From owner-freebsd-current@FreeBSD.ORG Tue May 1 11:19:11 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6A4B616A402 for ; Tue, 1 May 2007 11:19:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id 17A9313C484 for ; Tue, 1 May 2007 11:19:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.227] (helo=fw.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.60) (envelope-from ) id 1HiqNw-000Da6-Ov for freebsd-current@freebsd.org; Tue, 01 May 2007 14:19:09 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id l41BJ31J053479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 May 2007 14:19:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l41BJ2Q9037444; Tue, 1 May 2007 14:19:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l41BJ2wX037443; Tue, 1 May 2007 14:19:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 1 May 2007 14:19:02 +0300 From: Kostik Belousov To: Dag-Erling Sm?rgrav Message-ID: <20070501111902.GA2441@deviant.kiev.zoral.com.ua> References: <200704281128.44077.shoesoft@gmx.net> <20070428115503.GM2441@deviant.kiev.zoral.com.ua> <86y7k8rgc4.fsf@dwp.des.no> <86tzuwrfui.fsf@dwp.des.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DQpa7ozeLWh50je8" Content-Disposition: inline In-Reply-To: <86tzuwrfui.fsf@dwp.des.no> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.88.7, clamav-milter version 0.88.7 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-0.1 required=5.0 tests=ALL_TRUSTED,SPF_NEUTRAL autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on fw.zoral.com.ua X-Scanner-Signature: 3140350ce96b4815fe22a3a842dc7b15 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1012 [May 01 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: freebsd-current@freebsd.org, Stefan Ehmann Subject: Re: strace causes panic: sleeping thread X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:19:11 -0000 --DQpa7ozeLWh50je8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 12:35:49PM +0200, Dag-Erling Sm?rgrav wrote: > des@des.no (Dag-Erling Sm?rgrav) writes: > > procfs_ioctl() needs the process to be locked; pn_ioctl() verifies > > that this is the case before calling it. The correct fix is not to > > unlock the process before calling procfs_ioctl(), but to remove the > > latter's redundant PROC_LOCK() / PROC_UNLOCK() calls. >=20 > See attached patch. The procfs PIOCWAIT/PIOCWAIT32 ioctls drop the p_mtx for sleep. Could it be that p being freed/reused meantime ? --DQpa7ozeLWh50je8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGNyImC3+MBN1Mb4gRAvSpAKCxsNVuN4V3MkeVZXuJkL6d1QtHowCfWM3x UxWw3VO5nGN9USJaX546pAk= =ExWq -----END PGP SIGNATURE----- --DQpa7ozeLWh50je8--