From owner-svn-src-all@freebsd.org Wed Oct 7 22:35:38 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5D0C9D13F7; Wed, 7 Oct 2015 22:35:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 770C590D; Wed, 7 Oct 2015 22:35:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicfx3 with SMTP id fx3so3903919wic.1; Wed, 07 Oct 2015 15:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=j02LJDP28xVqqDQONrvusuWpue8D5HxLvtGjb61RNd0=; b=pYceH96c6r80JBxc/MLKImRVlNjBlBSIbhLa7fUZJoINsQYKK1tZZJv/CXGMQjnuMX HXsRhj8TdmjPKFs6/zPIhbb10yjTA+xBTMa3KSi1P5ixYyllxN0gmF2n0P3dHPLxykG3 DrvyWKSBB/YdgSWS31+GZhxVxDV7hrHIQCdzsGZ2oDLBvN6wNdGRcylp4YWKJl9zFN4a VHftHY1pvNFsr/TQrxs3Lsc176wOM9n3qqP0lJyEAX23lyBzvMyiyJ/DKELRnVx3xgUT CK1tmTTGQOCPNRUAdObDzPSe5Xr/oWJNjKeO55v6BsiBO3G0Kbbljyt7SXCp4WHfZRd4 5TGA== X-Received: by 10.180.102.195 with SMTP id fq3mr118713wib.7.1444257336038; Wed, 07 Oct 2015 15:35:36 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id s1sm4448631wik.16.2015.10.07.15.35.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Oct 2015 15:35:35 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 8 Oct 2015 00:35:33 +0200 From: Baptiste Daroussin To: Conrad Meyer Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r288984 - head/sbin/sysctl Message-ID: <20151007223533.GF91729@ivaldir.etoilebsd.net> References: <201510070928.t979SsMQ057994@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="L2Brqb15TUChFOBK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 22:35:39 -0000 --L2Brqb15TUChFOBK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 07, 2015 at 02:56:02PM -0700, Conrad Meyer wrote: > On Wed, Oct 7, 2015 at 2:28 AM, Baptiste Daroussin wro= te: > > --- head/sbin/sysctl/sysctl.c Wed Oct 7 09:12:49 2015 (r28898= 3) > > +++ head/sbin/sysctl/sysctl.c Wed Oct 7 09:28:54 2015 (r28898= 4) > > @@ -276,7 +276,11 @@ parse(const char *string, int lineno) > > if (qflag) > > return (1); > > else { > > - warn("unknown oid '%s'%s", bufp, line); > > + if (errno =3D=3D ENOENT) { > > + warnx("unknown oid '%s'%s", bufp, line); > > + } else { > > + warn("unknown oid '%s'%s", bufp, line); >=20 > Is "unknown oid" an appropriate warning for errno !=3D ENOENT? I do not think it is, but I couldn't find a way to reproduce another case t= han ENOENT, so I thought maybe the best would be to keep the current behaviour = for other cases :) Best regards, Bapt --L2Brqb15TUChFOBK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYVnjUACgkQ8kTtMUmk6ExvPgCgqRAfz3BxreD1eoS2QFdWfklV 3BQAnjRos9wGMxd6ou/yGjghNw5EJIIg =lSMh -----END PGP SIGNATURE----- --L2Brqb15TUChFOBK--