From owner-cvs-all Mon Sep 17 6:48:45 2001 Delivered-To: cvs-all@freebsd.org Received: from shell.futuresouth.com (shell.futuresouth.com [198.78.58.28]) by hub.freebsd.org (Postfix) with ESMTP id F389A37B408; Mon, 17 Sep 2001 06:48:40 -0700 (PDT) Received: (from fullermd@localhost) by shell.futuresouth.com (8.11.6/8.11.1) id f8HDm3W95528; Mon, 17 Sep 2001 08:48:03 -0500 (CDT) Date: Mon, 17 Sep 2001 08:48:03 -0500 From: "Matthew D. Fuller" To: Peter Wemm Cc: Akinori MUSHA , Alexander Langer , Matt Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/contrib/cvs/src checkout.c cvs.h entries.c update.c update.h Message-ID: <20010917084803.Z99062@futuresouth.com> References: <868zfgbpye.wl@archon.local.idaemons.org> <20010915130025.544AB380A@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010915130025.544AB380A@overcee.netplex.com.au>; from peter@wemm.org on Sat, Sep 15, 2001 at 06:00:25AM -0700 X-OS: FreeBSD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Sep 15, 2001 at 06:00:25AM -0700, a little birdie told me that Peter Wemm remarked > > * the tag stuff is *really* revolting code. It needs a lot of work to get > around arbitary restrictions (eg: only one tag), silly syntax, etc. FWIW, I can heartily second this. I went through the code some time ago and updated it to support up to 3 tag substitutions, and it was some of the vilest hack-perpetuation I've ever done; I basically had to go through a few parts of the code and triple the amount of special-casing. A dynamic rewrite of this would be worth a lot. I made a quick pass at it at the time, but it got pretty far-reaching pretty fast, so I just threw in the 3-tag hardcoding which was sufficient for my needs at the time. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Unix Systems Administrator | fullermd@futuresouth.com Specializing in FreeBSD | http://www.over-yonder.net/ "The only reason I'm burning my candle at both ends, is because I haven't figured out how to light the middle yet" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message