From owner-freebsd-audit Thu Feb 8 7:38:54 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 8C4E037B401 for ; Thu, 8 Feb 2001 07:38:34 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f18FcWu40865; Thu, 8 Feb 2001 10:38:32 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G8G000JN3G6FC@gkar.cc.vt.edu>; Thu, 8 Feb 2001 10:38:30 -0500 (EST) Date: Thu, 08 Feb 2001 10:38:30 -0500 (EST) From: Mike Heffner Subject: Re: lam(1) patch In-reply-to: <200102072318.f17NIj996425@harmony.village.org> To: Warner Losh Cc: FreeBSD-audit Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.7 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 07-Feb-2001 Warner Losh wrote: | In message Mike Heffner writes: |: | Also available from: |: | http://filebox.vt.edu/users/mheffner/patches/lam.patch |: Any objections to me committing this? [ snip ] |: Also, should I follow it up with a de-__P() patch? | | Yes. So long as you make all the old K&R style decls into ANSI ones | at the same time. | Ok, after screwing up the last style patch, here is a the latest version I've put together. I think this fulfills all the style(9) requirements and everyones comments from the last patch (accept keeping the K&R style). Spaces after function names were removed and the char** has been restored to char *[]. Index: lam.c =================================================================== RCS file: /home/ncvs/src/usr.bin/lam/lam.c,v retrieving revision 1.6 diff -u -r1.6 lam.c --- lam.c 2001/02/08 05:58:55 1.6 +++ lam.c 2001/02/08 15:28:50 @@ -73,13 +73,13 @@ char line[BIGBUFSIZ]; char *linep; -char *gatherline (struct openfile *); -void getargs (char **); -char *pad (struct openfile *); -static void usage (void); +char *gatherline(struct openfile *); +void getargs(char *[]); +char *pad(struct openfile *); +static void usage(void); int -main(int argc, char **argv) +main(int argc, char *argv[]) { struct openfile *ip; @@ -100,7 +100,7 @@ } void -getargs(char **av) +getargs(char *av[]) { struct openfile *ip = input; char *p, *c; (also at: http://filebox.vt.edu/users/mheffner/patches/lam.style.patch) -- Mike Heffner Blacksburg, VA http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message