From owner-freebsd-current@FreeBSD.ORG Wed Apr 6 13:43:33 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13C03106566B for ; Wed, 6 Apr 2011 13:43:33 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id B19BD8FC1B for ; Wed, 6 Apr 2011 13:43:32 +0000 (UTC) Received: from outgoing.leidinger.net (p5B1561B0.dip.t-dialin.net [91.21.97.176]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id EB8E1844018; Wed, 6 Apr 2011 15:43:28 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 224F7155E; Wed, 6 Apr 2011 15:43:26 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p36DhPGK037130; Wed, 6 Apr 2011 15:43:25 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 06 Apr 2011 15:43:25 +0200 Message-ID: <20110406154325.157845mc2tp09mgw@webmail.leidinger.net> Date: Wed, 06 Apr 2011 15:43:25 +0200 From: Alexander Leidinger To: Kostik Belousov References: <4D9BBED1.3070402@freebsd.org> <20110406102143.GG78089@deviant.kiev.zoral.com.ua> In-Reply-To: <20110406102143.GG78089@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: EB8E1844018.A1304 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=0, required 6, autolearn=disabled) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1302702209.79979@H8MEcS5PQDiZmSnHBBiFZA X-EBL-Spam-Status: No Cc: FreeBSD Current Subject: Re: kernel thread creation cleanup X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2011 13:43:33 -0000 Quoting Kostik Belousov (from Wed, 6 Apr 2011 13:21:43 +0300): > On Tue, Apr 05, 2011 at 06:16:01PM -0700, Julian Elischer wrote: >> I was just looking in the thread creation code after most of a decade >> NOT looking at it.. >> boy we really need to go through there with a broom.. the cobwebs are >> getting thick. >> Like we always call the code to put an upcall, even though we don't >> have upcalls any more, > cpu_set_upcall() probably could be renamed to cpu_init_thread(), > and cpu_set_upcall_kse() is better named cpu_init_thread_for_user(). > > IMO, rename would only add a code churn. Do not underestimate the impact of misnamed functions. Do not underestimate the usefulness of correcly named functions. Does a change help other developers (to understand or extend) or improves what we have: it is not code churn. Bye, Alexander. -- You can move the world with an idea, but you have to think of it first. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137