From owner-freebsd-current Sun May 31 23:14:29 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA08355 for freebsd-current-outgoing; Sun, 31 May 1998 23:14:29 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA08349 for ; Sun, 31 May 1998 23:14:26 -0700 (PDT) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id QAA13173; Mon, 1 Jun 1998 16:14:23 +1000 Date: Mon, 1 Jun 1998 16:14:23 +1000 From: Bruce Evans Message-Id: <199806010614.QAA13173@godzilla.zeta.org.au> To: bde@zeta.org.au, n@nectar.com Subject: Re: union nethostaddr no longer defined for src/sbin/mount_nfs.c Cc: freebsd-current@FreeBSD.ORG Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >You'd have to also back out revision 1.27 of >src/sbin/mount_nfs.c of the same date. No, rev.1.33 of src/sys/nfs/nfs.h is a prerequisite for rev.1.27 of src/sbin/mount_nfs/mount_nfs.c, so clobbering of rev.1.33 in rev.1.40 broke mount_nfs.c. >If a structure needs to be visible to userland utilities, it >shouldn't be in a KERNEL section, IMHO. For that matter, I >sometimes think there ought to be more header.h/headervar.h >pairs instead of #ifdef KERNEL everywhere. That's why `union nethostadr' moved it outside the KERNEL section. It probably doesn't need to be visible, but it is used in other nfs headers that don't even have a KERNEL section. >I guess the question in my mind is which is more important >with regards to the NFS code: > >* Progress towards a less ``polluted'' environment, OR >* Kernel and header source code compatibility with other > BSD systems I don't like pollution, but implemented consistent pollution. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message