Date: Sun, 23 Mar 2008 18:20:18 +0800 From: "Rong-en Fan" <grafan@gmail.com> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: perl@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: [PATCH] archivers/p5-Compress-LZW: CPAN Macro Message-ID: <6eb82e0803230320y6a5e9499ne05ebc3ab0530eaa@mail.gmail.com> In-Reply-To: <47E61388.40303@p6m7g8.com> References: <200803230517.m2N5Hw6v070612@piccollo.p6m7g8.net> <6eb82e0803230054p657679bdxbc7f483a3ad1df7d@mail.gmail.com> <47E61388.40303@p6m7g8.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 23, 2008 at 4:23 PM, Philip M. Gollucci <pgollucci@p6m7g8.com> wrote: > Rong-en Fan wrote: > > First, when you using CPAN, it has SUBDIR set to the correct > > directory if you use module's name as PORTNAME. > D'oh I didn't see that logic in bsd.*mk > > > > Second, I'm not sure if this is a good idea to that just switch to the macro > > without any version update. > Since when has a port update to newer FreeBSD ports architecture needed > a version update too? I think there is a tradition to do so if this is done port by port. I believer this kind of change should be done in one big commit if this is the way to go. > What about port@ ports? perl@ is not ports@. > Also, what about ports that use authors path one ? > archivers/p5-IO-Zlib > -MASTER_SITE_SUBDIR= ../../authors/id/T/TO/TOMHUGHES It's not supported by the CPAN module. But it IO/ contains IO::Zlib, then remove the authors subdir (IIRC, this is a long term goal of perl ports). > > If perl@ thinks that we are going to use CPAN macro by default, > > then perhaps change all perl@ maintained ports at once will > > be better. > Even is thats the case, I can still submit one patch for it perl@ agrees. Yes, but I suggest that you submit one PR for all perl@ ports. :-) Regards, Rong-En Fan > > -- > ------------------------------------------------------------------------ > Philip M. Gollucci (pgollucci@p6m7g8.com) > c:703.336.9354 > Consultant / http://p6m7g8.net/Resume/resume.txt > http://riderway.com / http://ridecharge.com > 1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF > > Work like you don't need the money, > love like you'll never get hurt, > and dance like nobody's watching. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6eb82e0803230320y6a5e9499ne05ebc3ab0530eaa>