From owner-dev-commits-src-main@freebsd.org Mon Apr 26 22:29:12 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 45C0D5F2C66; Mon, 26 Apr 2021 22:29:12 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-qb1can01on0623.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5c::623]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTfh80XxKz4f8d; Mon, 26 Apr 2021 22:29:11 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mV3WrNAHN8SqY6wE2gH+VUk+IEQhh6PIgHmG7OCnvAs9/nnbxa0RB7T7qVlyfulnQIkWa+0kaI41bv6kD1PP4q5v45DdRm9cIOvTAw0C2eyijQanjKQ0C3I7z7/otqUSCtqpCPSBSAyDe+IGXcvz+PHJNlhKMUO5eDGl4pKNYiBdpoNYLPlonqRYucNO9ucXG2FHYwkGcPhJ2ZKFIYaQZ4U/pxfKY7LbrQIJNhYB2Azg5O+dHeu8Z6rnM+ghiBqoAck9eyiDbcDRlY4l15FoQ62vHfaIPLiWGrUBdJucNu5nnoWYvZxSmW6uTWGkR4/TtGwrFFT/9JnjWt0A43IhsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nrVoiMmndexZXuqzc1jRp2GuxJezkCXulQDSh91YtWE=; b=hHS1Ah8cLSBKvn21ySJ+4eevMUFMZZVmefIKygwS78eAN7XPlZCuKok/z5sDd31u/9fkamOStELVhs/y9ZfNuXXejPUCWnrSaE4tsi3AOBRCUfLSvwbZ6n/Nlq8dkuwz+aALZ5JlTlruORdMeh6oZD5AaGCvrddypMKr0Ses6s0pozVF8bKyM22CTBO6g+1/QWUM/KZTes49vZiQs2Lt9tDf6EVbysd8KTV5EermODCNSF2qBpTMQ5o+n96KjR9IxA4g4wo7tlCGc+Mqe5kD7innIIZCRYH5wnGDBOf2R5dx+HdB4ZNlP2r5hUXr3FQtlA+9Ub+1naEar7eL9FMB+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nrVoiMmndexZXuqzc1jRp2GuxJezkCXulQDSh91YtWE=; b=AP+m4xExZX42yppAa79WwgXRcTRAk62qfMynH7PAmMoVXunH6woCKHW9SL7bRo7UpZGKjOzTV//0Bnskx7No4CQMqaXICzc8ffwEClMFcJXLSNCmedsW2p38qgZsvtV8A5S3m8E2KYcnRnBI5ENrs5wzDe98ihaDWYmtaVj+NVS9k7dyu0G0bZywIWWrXUX5eLGYB+/MZ7bbqyiXSsIioayY/3GfrjsxDLeo/2Em/oCMZyUPbPNTjFg5z3z7ThvF14gvh0sWwn2dvvJrSqHzStavLRUVgkqs13PC+pW3/YVgxcJHoWaacbV3sw0JNuWsb5Ekx6Vm3Of6lR02sXDTxA== Received: from YTOPR0101MB0970.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:20::29) by YT1PR01MB2857.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Mon, 26 Apr 2021 22:29:09 +0000 Received: from YTOPR0101MB0970.CANPRD01.PROD.OUTLOOK.COM ([fe80::21d4:df53:c6e9:5ba8]) by YTOPR0101MB0970.CANPRD01.PROD.OUTLOOK.COM ([fe80::21d4:df53:c6e9:5ba8%6]) with mapi id 15.20.4065.027; Mon, 26 Apr 2021 22:29:03 +0000 From: Rick Macklem To: Neel Chauhan , Kevin Bowling CC: src-committers , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" Subject: Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() Thread-Topic: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() Thread-Index: AQHXOrB0UGsvOu+7hUGes3oAD6tpP6rHAlcAgAABNgCAAFyIbg== Date: Mon, 26 Apr 2021 22:29:03 +0000 Message-ID: References: <202104261525.13QFPrbg086311@gitrepo.freebsd.org> , <9b006e97a64d01d128d81bc09f0891ea@freebsd.org> In-Reply-To: <9b006e97a64d01d128d81bc09f0891ea@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 119af3ac-e8f9-4b92-dc8c-08d90902b25b x-ms-traffictypediagnostic: YT1PR01MB2857: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Om3aiFmz02mmBkn2f+kPmW21vtGtGP31Y9SNB7l9g/hwFbLqjT6YfshKjltwzkG6SzV3ZW2weLPgbpEEP54Z4jFRoE8vIPrQDMnQaTsCaiXP2yn1kA7CIXD5AqmGvnIyLdeu9v0ii6k9ynVbVKuKTxSRbAVs4oyOF+5xNSSuEVzquTceru9ufQIf9T/8Lz5DtlZX+ZCcw4Cd5bRFREgjsFKX1pTU9lyBphzr0zps4xwCwLD1gi+6l8XEjyTvPdw8TN7AbF7a4sIaE3fiyqbHLdOU20uJZlYikbk87vpEQWwy/pmkuBKHvPRZVt6RNS6T+BSbzJSjEohErn/rX1jmMM6gafbt7za4R3d/LQAdVItKApPHaMJ1g3gRUYKzyNN1JHysxYYN7N6MiO/7pVLrv4Ir8O9Jq2BgXelnn2h5pRlZhIzIgt53A802EzjB5LbU8nkuWhtMNix+0YvWE/7JZP2TvMH/k5VlcrK+fEWPnLtks4Oh9XetrGlA0L+RtFF08hVrATd72ntZ7WAB6EhUwgFKL0XzxAEvLii8Wph3mjvy+8nOR93DDBtNwPdKWo4wbcP15ufGc7k4DA9UlH/F++tK7djPyQLQZ96KE800u7n9LSidOsol47XTOY7x0qr1zp01ffbzQesfQ/qIoiGpqUM8httFjnlsY3YFUYUvLyTt5p3mC6iTxpExTlW5JH0ZfuqyiF/Za8kWiA56LbGL22+yDAbuA7xsbpZVH/tGIGc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YTOPR0101MB0970.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(136003)(366004)(396003)(39860400002)(376002)(346002)(66476007)(71200400001)(33656002)(8676002)(966005)(66556008)(91956017)(54906003)(186003)(5660300002)(86362001)(4326008)(83380400001)(76116006)(478600001)(64756008)(66946007)(66446008)(9686003)(55016002)(786003)(316002)(110136005)(122000001)(6506007)(8936002)(52536014)(38100700002)(7696005)(2906002)(125773002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?4ONaxj/uo0KgRq5tNdystG6TSE1bZC672sQLUHGcZ/VuS/8gon+yFC3T?= =?Windows-1252?Q?qnKorjm/CmeMp/wzSW5bp52gQWjDSSBvAqNvxRkmFwpsWxeXd2THiSgO?= =?Windows-1252?Q?REGlc9zESPNQV6rX9QcG6Fi3AYsmLl9wyLzbl/UPJew27Q/n8qWCe738?= =?Windows-1252?Q?QQutCSSjfp2M9CDAfAAPJZYHwyiRWvMAXpfOWBoB2lFprupXqEaWcGra?= =?Windows-1252?Q?LFJobYmlZ9haFSQmf0LjTkhKb3JaOY+q3Elp4geRvb95KIHp47cHE7Di?= =?Windows-1252?Q?O5cLbpvaKZyOtmY2AJGPHY8BtcLMwQOcEomL2JnZmcLn5+NNC57rLreC?= =?Windows-1252?Q?FmOWFcdsjgFULNX5CUIDdA+CXGSLCK5+SaRR9dcQcHZyWNcQhenIxU8R?= =?Windows-1252?Q?9BoqAVawUputhuri6eKHL/logMHkzC+v4oKIBPTAtG3oqQuGCZaePE1e?= =?Windows-1252?Q?O63e7ebUxp9q2ZMSeCY2lio3E071coSvdiPp6v/HYMiwS8LUTgtVqyQz?= =?Windows-1252?Q?fRgBneNyaDPcowKAGTSjO/3Uj2D2rBlVlecBe1XNcc7Ox+uuxSXVf2P/?= =?Windows-1252?Q?Tb77f1a1wB6izQDnv6ZVJPGVPDt0ggNC+8QFS6Mg2Ui5risIa2TI2+pV?= =?Windows-1252?Q?4ZNCNc6T2BE80djGg/IweKt2k/Eg8WSL6wi6cK43oSrpMfTWnsx9YASf?= =?Windows-1252?Q?Jpd+wvqKEtnEQFf0QNtJkrvcU+a3huQoXIkgEGjlhdqY71fhSeIvst6H?= =?Windows-1252?Q?4P5S2Mq6dZon+nMvmdA+UINbNy2fARSTrLQM/HdDCztk1k/dcxKUKaeu?= =?Windows-1252?Q?on/KAyLYoGOMaqXZEmp5zp0gdpeRAPmE5cvYeJJv1fW7TJu5qZA+qTN/?= =?Windows-1252?Q?BVcY5zvIkl7c09hb76nOjMsZl30U6yPnQUrYXSGK6XgecSK4UT+MAVRk?= =?Windows-1252?Q?dxpr/ns1dy8fK7IRTFaHhQNvk+BK7MTQfd0Q1wgdpI9GBul9NFkn3NxD?= =?Windows-1252?Q?Gm759S6Amak+EV5goLcPLV133ag81l14cS2GJrvbOTomRn0H0mxdEhRM?= =?Windows-1252?Q?h0KqrLJx5TuNnDT5uvkFZa4uwHQdIvy0NNV7sygbZmKVWaQjkHO04BQ4?= =?Windows-1252?Q?k1EiQT0KDWrhCPCPUICkth20N+5N4rrkIw29ai3W6JfnbpbIqYXU3vkk?= =?Windows-1252?Q?r6qv7Zs/2ILj5iaTRKsjVEOJV0jJlTxCnrrqlLpre9lawev7Syz4Ne+7?= =?Windows-1252?Q?bTV9VqOmkkr4bJhvpMwazatrOWNABMaoNbmYuYhzbtESKjncHRBceg08?= =?Windows-1252?Q?JHdyXKTxf3ltuwZcoXeCh8vM/yAcXZ7/gvIuiRpeil7GyVe2G81mpvTX?= =?Windows-1252?Q?NjznyuHwqn+AsjWX3h5unSkL+wr9s/jYA0FJpF+ItmpdExcdMFtEK2F8?= =?Windows-1252?Q?d6EIRo9dGc/7PPV8kn4ZVpjDqKgxnLZ81Xt4Pwd+nkPn0KYnWc0CwKVo?= =?Windows-1252?Q?zHm50OGk?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YTOPR0101MB0970.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 119af3ac-e8f9-4b92-dc8c-08d90902b25b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 22:29:03.5695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nqPV1Uj3lJ6y++XV/Kj3PBH/XpmLIzWAFE2ZOXu277sDH4cL3harqBsJTTswNPqo6BrKqoWw7LJZsCX5rz28kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB2857 X-Rspamd-Queue-Id: 4FTfh80XxKz4f8d X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 22:29:12 -0000 Neel wrote:=0A= >On 2021-04-26 09:47, Kevin Bowling wrote:=0A= >> I'm not sure all the context or conversation here but the convention=0A= >> is to not use bare return values, i.e in style(9) "Values in return=0A= >> statements should be enclosed in parentheses." and that's what was=0A= >> asked to be changed on this mailing list.=0A= Just fyi to everyone, there is this in style(9):=0A= In general code can be considered =93new code=94 when it makes up abou= t 50%=0A= or more of the file(s) involved. This is enough to break precedents i= n=0A= the existing code and use the current style guidelines.=0A= =0A= As such, if the "return 0;" predates this patch series, Neel is correct=0A= to use "return 1;", since that precedent has already been established.=0A= I'll admit I see the above ignored a lot and personally don't care if=0A= the above generality is followed, but it is in style(9) and I do=0A= think a consistent style is preferred over a jumble within a source file.= =0A= =0A= rick=0A= =0A= The review: https://reviews.freebsd.org/D29988=0A= =0A= I believe I was asked to do this in the review.=0A= =0A= -Neel=0A= >=0A= > Can you use and link to Phabricator for your src commits? As much as=0A= > possible it is preferable to get it right in one go, for MFCs,=0A= > bisection, etc and this kind of churn should be preventable with quick=0A= > reviews. Feel free to tag me as a reviewer.=0A= =0A= Sure, will do next time.=0A= =0A= =0A= > Regards,=0A= > Kevin=0A= =0A= -Neel=0A= =0A=