From owner-freebsd-stable  Tue Jun 25 12:29:32 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from mail.sandvine.com (sandvine.com [199.243.201.138])
	by hub.freebsd.org (Postfix) with ESMTP id EF11337B403
	for <freebsd-stable@freebsd.org>; Tue, 25 Jun 2002 12:29:27 -0700 (PDT)
Received: by mail.sandvine.com with Internet Mail Service (5.5.2653.19)
	id <NGG7SVGD>; Tue, 25 Jun 2002 15:29:26 -0400
Message-ID: <FE045D4D9F7AED4CBFF1B3B813C853376765C1@mail.sandvine.com>
From: Don Bowman <don@sandvine.com>
To: 'Jonathan Lemon' <jlemon@flugsvamp.com>,
	"'freebsd-stable@freebsd.org'" <freebsd-stable@freebsd.org>
Subject: RE: panic in syncache/rtfree with 4.6
Date: Tue, 25 Jun 2002 15:29:19 -0400
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG


in tcp_syncache.c, it seems that syncache_lookup()
calls need to be protected by splnet()/splx().

For example, in syncache_chkrst(), the code does:

sc = syncache_lookup(...)
if (sc == NULL)
	return
if (sc->...)
      syncache_drop(sc, ...)


however, if the timer wakes up between the lookup() and the
rest of the function, will a crash not occur?
Shouldn't this be protected from before the lookup until
after the last use of sc?

--don

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message