From owner-cvs-sys Sun Mar 1 05:47:52 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA15411 for cvs-sys-outgoing; Sun, 1 Mar 1998 05:47:52 -0800 (PST) (envelope-from owner-cvs-sys) Received: from gvr.gvr.org (root@gvr.gvr.org [194.151.74.97]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA15279; Sun, 1 Mar 1998 05:47:39 -0800 (PST) (envelope-from guido@gvr.org) Received: (from guido@localhost) by gvr.gvr.org (8.8.6/8.8.5) id OAA19174; Sun, 1 Mar 1998 14:47:32 +0100 (MET) From: Guido van Rooij Message-Id: <199803011347.OAA19174@gvr.gvr.org> Subject: Re: cvs commit: src/sys/conf param.c In-Reply-To: <199803010214.TAA07191@pluto.plutotech.com> from "Justin T. Gibbs" at "Feb 28, 98 07:11:33 pm" To: gibbs@plutotech.com (Justin T. Gibbs) Date: Sun, 1 Mar 1998 14:47:32 +0100 (MET) Cc: guido@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > Raise ncallout from NPROC + 16 to NPROC + 16 + MAXFILES. This shold > > prevent a possible DOS attack. The proper fix (to dynamically grow > > the callout list) is in the make. > > Submitted by: Paul Traina > > > > Revision Changes Path > > 1.26 +5 -4 src/sys/conf/param.c > > We should probably continue the discussion that was started a while back > about having clients allocate their own callouts. Some areas of the system > can gracefully handle resource shortages if they can determine there is a > shortage up front (e.g. CAM when allocating CCBs). Having an allocation > fail at the time of "timeout" is too late to take corrective action and > is problematic as timeout may occur in an interrupt context. I know it is problematic. But I prefer a (quick) alloc over a panic. What you propose can be done together with allocation in timeout. -Guido