From owner-freebsd-current Tue May 29 9:43:58 2001 Delivered-To: freebsd-current@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 0AD9337B422; Tue, 29 May 2001 09:43:56 -0700 (PDT) (envelope-from jhb@foo.osd.bsdi.com) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f4TGhsK04760; Tue, 29 May 2001 09:43:54 -0700 (PDT) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.1) id f4TGhrv58166; Tue, 29 May 2001 09:43:53 -0700 (PDT) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010526022209.CA0203E2F@bazooka.unixfreak.org> Date: Tue, 29 May 2001 09:43:53 -0700 (PDT) From: John Baldwin To: Dima Dorfman Subject: RE: vm_pager_(de)allocate and vm_mtx Cc: alfred@FreeBSD.ORG, current@FreeBSD.ORG Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 26-May-01 Dima Dorfman wrote: > Is there a reason vm_pager_allocate acquires vm_mtx itself if > necessary but vm_pager_deallocate does not? At the moment, detaching > an md(4) disk will panic the system with a failed mtx_assert in > vm_pager_deallocate. This can be fixed one of two ways: > vm_pager_deallocate could be made to deal with vm_mtx itself like > vm_pager_allocate does, or md(4) and any other drivers which call > vm_pager_deallocate can be fixed to acquire vm_mtx. So which will it > be? I'll supply patches for either case. > > Thanks, I think I have it the same in the patches on my laptop, but I've not finished those yet, so they aren't safe to be committed but are still a WIP. I would grab the lock around vm_pager_deallocate() for now. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message