From owner-freebsd-pkg@FreeBSD.ORG Thu Feb 19 03:14:53 2015 Return-Path: Delivered-To: freebsd-pkg@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E98DDC28 for ; Thu, 19 Feb 2015 03:14:52 +0000 (UTC) Received: from relay2.tomsk.ru (mail.sibptus.tomsk.ru [212.73.124.5]) by mx1.freebsd.org (Postfix) with ESMTP id 4A675EC0 for ; Thu, 19 Feb 2015 03:14:51 +0000 (UTC) X-Virus-Scanned: by clamd daemon 0.98.5_1 for FreeBSD at relay2.tomsk.ru Received: from admin.sibptus.tomsk.ru ([212.73.125.240] verified) by relay2.tomsk.ru (CommuniGate Pro SMTP 5.1.16) with ESMTPS id 38244037; Thu, 19 Feb 2015 09:14:49 +0600 Received: from admin.sibptus.tomsk.ru (sudakov@localhost [127.0.0.1]) by admin.sibptus.tomsk.ru (8.14.9/8.14.7) with ESMTP id t1J3Eke1033570; Thu, 19 Feb 2015 09:14:49 +0600 (NOVT) (envelope-from vas@mpeks.tomsk.su) Received: (from sudakov@localhost) by admin.sibptus.tomsk.ru (8.14.9/8.14.7/Submit) id t1J3EkTf033569; Thu, 19 Feb 2015 09:14:46 +0600 (NOVT) (envelope-from vas@mpeks.tomsk.su) X-Authentication-Warning: admin.sibptus.tomsk.ru: sudakov set sender to vas@mpeks.tomsk.su using -f Date: Thu, 19 Feb 2015 09:14:46 +0600 From: Victor Sudakov To: Mathieu Arnold , freebsd-pkg@freebsd.org Subject: Re: "poudriere distclean" complains about /etc/make.conf Message-ID: <20150219031446.GA32820@admin.sibptus.tomsk.ru> References: <20150217043049.GA68755@admin.sibptus.tomsk.ru> <20150218163739.GA24716@admin.sibptus.tomsk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: OAO "Svyaztransneft", SibPTUS X-PGP-Key: http://www.dreamwidth.org/pubkey?user=victor_sudakov X-PGP-Fingerprint: 10E3 1171 1273 E007 C2E9 3532 0DA4 F259 9B5E C634 User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-pkg@freebsd.org X-BeenThere: freebsd-pkg@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Binary package management and package tools discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 03:14:53 -0000 Mathieu Arnold wrote: > +--On 18 f??vrier 2015 22:37:39 +0600 Victor Sudakov > wrote: > | Mathieu Arnold wrote: > |> | > |> | I have the following construct in /etc/make.conf but not in > |> | /usr/local/etc/poudriere.d/make.conf: > |> | > |> | .if ${.CURDIR:M*/mail/spamassassin} && ${HOST} == "relay.sibptus.ru" > |> | EXTRA_PATCHES+=/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1 > |> | .endif > |> | > |> | When I run "poudriere distclean", it complains about this construct: > |> | > |> | WARNING (mail/spamassassin): "/etc/make.conf", line 15: > |> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} && ${HOST} == > |> | "relay.sibptus.ru") WARNING (mail/spamassassin): > |> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING > |> | (mail/spamassassin): make: fatal errors encountered -- cannot continue > |> | > |> | I have two questions. > |> | > |> | 1. Why does it complain? The conditional seems legit. > |> > |> It seems like it is, but it is not, it should be: > |> > |> .if !empty(.CURDIR:M*/mail/spamassassin) && ${HOST} == "relay.sibptus.ru" > |> EXTRA_PATCHES+=/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1 > |> .endif > |> > |> or > |> > |> .if ${.CURDIR:M*/mail/spamassassin} != "" && ${HOST} == > |> "relay.sibptus.ru" > | > | Sorry, Mathieu, your advice does not help: > | > | [root@svn ~] poudriere distclean -y > | [00:00:00] ====>> Gathering all expected distfiles for ports tree > | 'default' WARNING (mail/spamassassin): "/etc/make.conf", line 15: > | Malformed conditional (${.CURDIR:M*/mail/spamassassin} != "" && ${HOST} > | == "relay.sibptus.ru") WARNING (mail/spamassassin): > | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING > | (mail/spamassassin): make: fatal errors encountered -- cannot continue > > Ah, yes, HOST is not defined, it's why it fails, you need to add: > > HOST?= Mathieu, what makes you think that HOST is not defined? It's defined in the environment and should be available to make: [sudakov@relay ~] make -V HOST relay.sibptus.ru [sudakov@relay ~] > > before that line, because you can't compare an undefined variable with > anything. -- Victor Sudakov, VAS4-RIPE, VAS47-RIPN sip:sudakov@sibptus.tomsk.ru