From owner-freebsd-net@FreeBSD.ORG  Thu Dec 11 18:18:34 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 096E31065680;
	Thu, 11 Dec 2008 18:18:34 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com
	[66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id D38BD8FC1D;
	Thu, 11 Dec 2008 18:18:33 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from compute1.internal (compute1.internal [10.202.2.41])
	by out1.messagingengine.com (Postfix) with ESMTP id 659181E6DF7;
	Thu, 11 Dec 2008 13:18:33 -0500 (EST)
Received: from heartbeat1.messagingengine.com ([10.202.2.160])
	by compute1.internal (MEProxy); Thu, 11 Dec 2008 13:18:33 -0500
X-Sasl-enc: 0/L1gkxbnjobDAH76arPK1cWctvbZsQxXGLhGnZwFSGk 1229019512
Received: from empiric.lon.incunabulum.net
	(82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254])
	by mail.messagingengine.com (Postfix) with ESMTPSA id A052613B10;
	Thu, 11 Dec 2008 13:18:32 -0500 (EST)
Message-ID: <49415977.6010307@FreeBSD.org>
Date: Thu, 11 Dec 2008 18:18:31 +0000
From: "Bruce M. Simpson" <bms@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.18 (X11/20081205)
MIME-Version: 1.0
To: Qing Li <qingli@FreeBSD.org>
References: <200812100740.mBA7eqjO034924@freefall.freebsd.org>
In-Reply-To: <200812100740.mBA7eqjO034924@freefall.freebsd.org>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org, current@freebsd.org
Subject: Re: last call for L2/L3 rewrite code review
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Dec 2008 18:18:34 -0000

Hi,

Just skimming this I notice it uses the if_afdata[AF_INET] pointer 
purely for lltbl purposes; this clashes with the IGMPv3 code drop.

Please look in the bms_netdev branch, where I introduce a 'struct 
ip_ifinfo' to make more general use of that slot. IGMPv3 needs to store 
per-interface state for AF_INET, so this slot really needs to be shared 
with other AF_INET stuff.

Looks like it needs to be updated for VIMAGE also, hopefully others more 
familiar with this can help -- I am busy enough with non-programming 
activity as it is to get up to speed on this, although I have at least 
managed to print Julian's write-up...

Other than that, it looks like a much needed improvement and we are all 
very grateful for our work on this.

thanks
BMS