From owner-cvs-src@FreeBSD.ORG Mon Aug 16 03:00:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 487F416A4CE; Mon, 16 Aug 2004 03:00:21 +0000 (GMT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1D2B43D46; Mon, 16 Aug 2004 03:00:20 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i7G30Gg1019547; Sun, 15 Aug 2004 23:00:18 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20040816023851.GC3026@green.homeunix.org> References: <200408150624.i7F6OhhR074096@repoman.freebsd.org> <20040816014244.GB3026@green.homeunix.org> <20040816015108.GQ991@funkthat.com> <20040816023851.GC3026@green.homeunix.org> Date: Sun, 15 Aug 2004 23:00:14 -0400 To: Brian Fundakowski Feldman , John-Mark Gurney From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2004 03:00:21 -0000 At 10:38 PM -0400 8/15/04, Brian Fundakowski Feldman wrote: >On Sun, Aug 15, 2004 at 06:51:08PM -0700, John-Mark Gurney wrote: > > > > sure, I'd like a quick peak at the patch though (if it takes me > > more than a day, go ahead and commit). > >I'd very much like you to look it over. I haven't tested it, just >made the stylistic changes. If it were more complete (i.e. satisfy >bde), every spurious blank line (that is, all of them inside functions >which are not between variable declarations and code) would be gone, >too, but that can be kind of harsh. > >--- /usr/src/sys/kern/kern_event.c Sun Aug 15 15:44:41 2004 >+++ kern_event.c Sun Aug 15 22:36:25 2004 >@@ -232,7 +231,6 @@ > static int > filt_fileattach(struct knote *kn) > { >- > return (fo_kqfilter(kn->kn_fp, kn)); > } > In some cases, such as this one, you are removing a blank line which style(9) wants to have there. ISTR being told that if there are no local variables in a routine, there should be a blank line before the first executable statement. Looking at the man page, I think that is shown by the example: static void usage() { /* Insert an empty line if the function has no local variables. */ -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu