From owner-freebsd-stable@FreeBSD.ORG Tue Jan 20 02:45:28 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A3AF106566B; Tue, 20 Jan 2009 02:45:28 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.231]) by mx1.freebsd.org (Postfix) with ESMTP id EF7558FC0C; Tue, 20 Jan 2009 02:45:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so3026722rvf.43 for ; Mon, 19 Jan 2009 18:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=eo/92ai2Jal4GAPOqk23k6TxU5x70Oqky7EWZEBJSmA=; b=K14ic96bpCNmgxurDIEtGmmkmVgUPDCROkL1x3L1HVjZm58uVMZhNRSwFIh5qQ/fm0 uHbxx8MdcE4sOfLVnoMLuZuKnu+i4Pz6UAsWBso/MbUhDdBFxtW5A7ajlAHyxCVrVILy 4pEYeW4NfSwUGSTRw66y55P4/PPULD7uc8aak= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=DyAgOco1J/IMx7rMsgWCaITtOkAK2BqZ6XlJyc11DbAlZYrtGMm+telsq1GBMuga6G PpIi3HsJVAPrV2c1D0mcHRrMwwNm+8OI+mBvvQTimnBTKeRng/NdDkNotTQFjfQ/ZJ1I 5Sn/hh8Q5YcUO/j74Mwcrfz5x7eF+RaP4POfQ= Received: by 10.140.125.1 with SMTP id x1mr194519rvc.265.1232419527651; Mon, 19 Jan 2009 18:45:27 -0800 (PST) Received: from michelle.cdnetworks.co.kr ([211.53.35.84]) by mx.google.com with ESMTPS id b39sm4982363rvf.0.2009.01.19.18.45.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 19 Jan 2009 18:45:26 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.14.3/8.14.3) with ESMTP id n0K2jKSK080448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Jan 2009 11:45:20 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.14.3/8.14.3/Submit) id n0K2jJwa080447; Tue, 20 Jan 2009 11:45:19 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 20 Jan 2009 11:45:19 +0900 From: Pyun YongHyeon To: Jung-uk Kim Message-ID: <20090120024519.GB79785@cdnetworks.co.kr> References: <8dfae1c10901070639x67945324jeeecfcac647d7976@mail.gmail.com> <20090117044758.GB68290@cdnetworks.co.kr> <200901191633.37309.jkim@FreeBSD.org> <200901191833.51320.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901191833.51320.jkim@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: Sascha Holzleiter , freebsd-stable@freebsd.org Subject: Re: FreeBSD 7.1 Breaks re and rl Network Interface Drivers X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 02:45:28 -0000 On Mon, Jan 19, 2009 at 06:33:46PM -0500, Jung-uk Kim wrote: > On Monday 19 January 2009 04:33 pm, Jung-uk Kim wrote: > > I found something interesting. I have another RTL8169SC that works > > perfectly fine without the patch. The hardware revision is > > 0x18000000. After reading Linux driver (drivers/net/r8169c), I > > realised they use different masks for hardware revisions. With > > their logic, non-working chip seems to be 0x98000000 (8110SCe) > > while working chip seems to be 0x18000000 (8110SCd) with > > 0xfc800000. FYI... > > Now armed with the information, I made it work without reverting > memory mapped I/O. :-) > > http://people.freebsd.org/~jkim/re/re.current2.diff > http://people.freebsd.org/~jkim/re/re.stable2.diff > I like the patch. Since only RTL8169 family uses mask 0xfc800000 it would be even better we can limit checking scope for RTL8169SC by comparing PCI device id. I don't know what other side effect would happen if the mask 0xfc800000 would be used on 8101/8168 controllers. If the patch works on RTL8169SC would you commit the patch? I'd like to see multiple commits separated by each enhancements as the patch contains several fixes which are not directly related with the issue. -- Regards, Pyun YongHyeon