From owner-freebsd-ports@FreeBSD.ORG Tue Aug 4 07:03:33 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A58610656B4 for ; Tue, 4 Aug 2009 07:03:33 +0000 (UTC) (envelope-from mel.flynn+fbsd.ports@mailing.thruhere.net) Received: from mailhub.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id E917A8FC12 for ; Tue, 4 Aug 2009 07:03:32 +0000 (UTC) (envelope-from mel.flynn+fbsd.ports@mailing.thruhere.net) Received: from smoochies.rachie.is-a-geek.net (mailhub.rachie.is-a-geek.net [192.168.2.11]) by mailhub.rachie.is-a-geek.net (Postfix) with ESMTP id 090DB7E821; Mon, 3 Aug 2009 23:03:32 -0800 (AKDT) From: Mel Flynn To: freebsd-ports@freebsd.org Date: Mon, 3 Aug 2009 23:03:30 -0800 User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; ) References: <20090731173636.GA76357@owl.midgard.homeip.net> <4A7552C8.7020508@infracaninophile.co.uk> <4A75A813.10307@infracaninophile.co.uk> In-Reply-To: <4A75A813.10307@infracaninophile.co.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908032303.31094.mel.flynn+fbsd.ports@mailing.thruhere.net> Cc: Peter Jeremy Subject: Re: ports/*/jpeg "Thanks a lot guys" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2009 07:03:33 -0000 On Sunday 02 August 2009 06:52:03 Matthew Seaman wrote: > Similarly, programs that declare 'USE_MYSQL=NN' will have a LIB_DEPENDS > on libmysqlclient.so.X added to their dependency mix even if they contain > no compiled ELF binaries [See net-mgmt/cacti databases/phpmyadmin] That's because you use USE_MYSQL when you really want to include bsd.databases.mk and throw and error on specific mysql versions. This could be addressed as below and for similar Mk/* files, should it be needed: Index: Mk/bsd.database.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.database.mk,v retrieving revision 1.37 diff -u -r1.37 bsd.database.mk --- Mk/bsd.database.mk 21 Jul 2009 08:02:18 -0000 1.37 +++ Mk/bsd.database.mk 4 Aug 2009 06:59:12 -0000 @@ -158,7 +158,7 @@ .if (${USE_MYSQL} == "embedded") BUILD_DEPENDS+= ${LOCALBASE}/lib/mysql/libmysqld.a:${PORTSDIR}/databases/mysql${MYSQL_VER}-server .endif -.else +.elif (${USE_MYSQL} != "vcheck") LIB_DEPENDS+= mysqlclient.${MYSQL${MYSQL_VER}_LIBVER}:${PORTSDIR}/databases/mysql${MYSQL_VER}-client .endif .else Index: databases/phpmyadmin/Makefile =================================================================== RCS file: /home/ncvs/ports/databases/phpmyadmin/Makefile,v retrieving revision 1.108 diff -u -r1.108 Makefile --- databases/phpmyadmin/Makefile 30 Jun 2009 19:10:53 -0000 1.108 +++ databases/phpmyadmin/Makefile 4 Aug 2009 07:00:04 -0000 @@ -14,7 +14,7 @@ MAINTAINER= m.seaman@infracaninophile.co.uk COMMENT= A set of PHP-scripts to manage MySQL over the web -USE_MYSQL= yes +USE_MYSQL= vcheck IGNORE_WITH_PHP= 4 IGNORE_WITH_MYSQL= 323 40 41 USE_BZIP2= yes -- Mel