Date: Thu, 24 Nov 2011 23:55:16 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Florian Wagner <florian@wagner-flo.net> Cc: freebsd-fs@FreeBSD.org Subject: Re: Extending zfsboot.c to allow selecting filesystem from boot.config Message-ID: <4ECEBD44.6090900@FreeBSD.org> In-Reply-To: <4ECAC272.5080500@FreeBSD.org> References: <20111015214347.09f68e4e@naclador.mos32.de> <4E9ACA9F.5090308@FreeBSD.org> <20111019082139.1661868e@auedv3.syscomp.de> <4E9EEF45.9020404@FreeBSD.org> <20111019182130.27446750@naclador.mos32.de> <4EB98E05.4070900@FreeBSD.org> <20111119211921.7ffa9953@naclador.mos32.de> <4EC8CD14.4040600@FreeBSD.org> <20111120121248.5e9773c8@naclador.mos32.de> <4EC91B36.7060107@FreeBSD.org> <20111120191018.1aa4e882@naclador.mos32.de> <4ECA2DBD.5040701@FreeBSD.org> <20111121201332.03ecadf1@naclador.mos32.de> <4ECAC272.5080500@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 23/11/2011 00:25 Andriy Gapon said the following:
> Unfortunately the logs that you captured do not reveal a source of the problem.
> I think that it would make sense to set a breakpoint at the zfs_mount function
> ('b zfs_mount'). When the program stops at a break point, you can then 'step'
> through the code. Then examine all arguments upon function calls and local
> variables at the interesting places. For variables that are pointers please
> print their dereferenced value (like 'p *x'). This could be time consuming.
>
> Some more straightforward things to (re-)test.
> First, are you absolutely sure that the problem never happens without the patch?
> Could you please retest that? Please do not touch anything under /boot, just
> recompile zfsboottest with the patch reverted and run it a few time.
> Then, could you please test the patch with the code from head? Again, no need
> to change you real boot blocks, just checkout sys/boot from head, patch it,
> recompile zfsboottest and test it.
Or another idea is to use valgrind ... which I have actually done myself and
found the problem.
While I am working on a proper solution, please try this quick patch:
http://people.freebsd.org/~avg/zfsboot.read_mos.patch
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ECEBD44.6090900>