From owner-svn-src-head@FreeBSD.ORG  Sat Jan 24 19:50:28 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3DD3C41A;
 Sat, 24 Jan 2015 19:50:28 +0000 (UTC)
Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196])
 by mx1.freebsd.org (Postfix) with ESMTP id 2A91F8F1;
 Sat, 24 Jan 2015 19:50:28 +0000 (UTC)
Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net
 [76.21.10.192])
 by elvis.mu.org (Postfix) with ESMTPSA id D4F71341F85E;
 Sat, 24 Jan 2015 11:50:27 -0800 (PST)
Message-ID: <54C3F7F1.90808@freebsd.org>
Date: Sat, 24 Jan 2015 11:52:17 -0800
From: Alfred Perlstein <alfred@freebsd.org>
Organization: FreeBSD
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r277653 - head/sys/dev/netmap
References: <201501241949.t0OJnSCI054826@svn.freebsd.org>
In-Reply-To: <201501241949.t0OJnSCI054826@svn.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Jan 2015 19:50:28 -0000

Wasn't this pointed out by James K?

On 1/24/15 11:49 AM, Adrian Chadd wrote:
> Author: adrian
> Date: Sat Jan 24 19:49:27 2015
> New Revision: 277653
> URL: https://svnweb.freebsd.org/changeset/base/277653
>
> Log:
>    Change the permissions from 0660 to 0600.
>    
>    Otherwise people in wheel can do things with netmap, including
>    but not limited to promisc transmit/receive.
>    
>    Approved by:	luigi
>    MFC after:	1 week
>
> Modified:
>    head/sys/dev/netmap/netmap.c
>
> Modified: head/sys/dev/netmap/netmap.c
> ==============================================================================
> --- head/sys/dev/netmap/netmap.c	Sat Jan 24 19:13:03 2015	(r277652)
> +++ head/sys/dev/netmap/netmap.c	Sat Jan 24 19:49:27 2015	(r277653)
> @@ -3075,10 +3075,10 @@ netmap_init(void)
>   #ifdef __FreeBSD__
>   	/* support for the 'eternal' flag */
>   	netmap_dev = make_dev_credf(MAKEDEV_ETERNAL_KLD,
> -		&netmap_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0660,
> +		&netmap_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0600,
>   			      "netmap");
>   #else
> -	netmap_dev = make_dev(&netmap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0660,
> +	netmap_dev = make_dev(&netmap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
>   			      "netmap");
>   #endif
>   	if (!netmap_dev)
>