Date: Fri, 25 Aug 2017 01:11:42 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448704 - in head/games: . openrct2 openrct2/files Message-ID: <9fbf9446-7e48-b271-70b3-8bedebbc012f@FreeBSD.org> In-Reply-To: <201708241922.v7OJM7np042340@repo.freebsd.org> References: <201708241922.v7OJM7np042340@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--H5B69UhGd5FplgBqkbtiOTXRPJhoHuEQg
Content-Type: multipart/mixed; boundary="8DJkrdRBiN7D2qpw1rO6k9Vu1FbO7ensp";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <9fbf9446-7e48-b271-70b3-8bedebbc012f@FreeBSD.org>
Subject: Re: svn commit: r448704 - in head/games: . openrct2 openrct2/files
References: <201708241922.v7OJM7np042340@repo.freebsd.org>
In-Reply-To: <201708241922.v7OJM7np042340@repo.freebsd.org>
--8DJkrdRBiN7D2qpw1rO6k9Vu1FbO7ensp
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: fr
Le 24/08/2017 =C3=A0 21:22, Dmitry Marakasov a =C3=A9crit=C2=A0:
> +PORTNAME=3D openrct2
> +DISTVERSIONPREFIX=3D v
> +DISTVERSION=3D 0.1.1
> +CATEGORIES=3D games
> +EXTRACT_ONLY=3D ${PORTNAME}-${PORTNAME}-${DISTVERSIONPREFIX}${DISTVERS=
ION}_GH0${EXTRACT_SUFX}
So, the whole first part is called ${DISTNAME} and you are hardcoding
implementation details of USE_GITHUB. Also the last part is wrong,
EXTRACT_SUFX can be changed, with various USES, whereas USE_GITHUB
always use _GITHUB_EXTRACT_SUFX.
Also, it is the only distfile, so the EXTRACT_ONLY line is useless.
> +WRKSRC=3D ${WRKDIR}/OpenRCT2-${PORTVERSION}
WRKSRC is always correct when using USE_GITHUB. If you feel like you
need to change it, use GH_PROJECT=3D OpenRCT2 instead.
> Added: head/games/openrct2/files/pkg-message.in
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ head/games/openrct2/files/pkg-message.in Thu Aug 24 19:22:07 2017 (=
r448704)
> @@ -0,0 +1,10 @@
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D
> +
> +To complete the installation of this port, you need to download the fi=
le
> +https://github.com/OpenRCT2/title-sequences/releases/download/%%DISTVE=
RSIONPREFIX%%%%DISTVERSION%%/title-sequence-%%DISTVERSIONPREFIX%%%%DISTVE=
RSION%%.zip
> +and unpack it to %%PREFIX%%/share/%%PORTNAME%%/title.
> +
> +You need to follow https://openrct2.website/getting-started/index.html=
> +to finish installation.
> +
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D
Is there some kind of licensing issue that makes it impossible for the
port to install the files it needs ?
--=20
Mathieu Arnold
--8DJkrdRBiN7D2qpw1rO6k9Vu1FbO7ensp--
--H5B69UhGd5FplgBqkbtiOTXRPJhoHuEQg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJZn10vXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85INRwQAK+Hddgf8OW7ke6F3JZWTDX3
cAu2aa+ndG0s/VsE7w0bNH1wxox8CZfT2Cg3tcPU3++CiYwVqBdS/xchU3PXPOp9
0EnB7G5z4XEwY/e8i32J50MbfuoaiU7P7w/hAXFShZNuXr/QRmffOWmjRzLB7OvQ
N7n26ANgPMAc/AOn6uHlwmhGxlh9643EhfFf8hJk2ZjhtO8eAbeApXmXgugIGSTm
mV8YzXtT6xDt1RDTdP2Sp6zSUJPU+eYZ0+mrQH0NBSrU46MutC+6FG4B0FEP4JOJ
STsUi7YHkGQmzFW4FBJMHTm9+YUxyl1FjVsGxvecsNTGBGaeV2sxOxtHskC98DKm
flHvGQJfuBEPuIo12+oq3DH2MKWGzxwg18cqOiMK4qy5AS/xTqzQoUgI+ZbUy2KE
ySBoB4pufmVzjnH8v5IVyC90IJpfaeFhnBSZ600FlXbJCsjWZnydDMbBKMYpLGZG
+8eC90PVxcx8DU11A314eAdp5YFB3DisRlH+QfDGt10VWnu/Az6YdmyYxgwgqOm/
wfJsgurZ5hAFlaNc2HNAHzZZlYgoy22etADVVtQCCWdNpZLAsLydB2kAxFuI+nMG
j6htKLJopNRE35P7HEAqapChbOTcPrvrGluSaU8Y1QQfBTewDzetF3BZHNjzAqxE
Pq0D9RmCjd0OQL6s4JvJ
=S0oj
-----END PGP SIGNATURE-----
--H5B69UhGd5FplgBqkbtiOTXRPJhoHuEQg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9fbf9446-7e48-b271-70b3-8bedebbc012f>