From owner-svn-src-all@freebsd.org Sat Dec 14 19:28:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3A311D5289 for ; Sat, 14 Dec 2019 19:28:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47ZyHd0ly2z4flp for ; Sat, 14 Dec 2019 19:28:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x832.google.com with SMTP id j5so2179351qtq.9 for ; Sat, 14 Dec 2019 11:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CR24ckpewZdjYMNelax3MWbcJ+vLZz6wVxjwYah6JnI=; b=jBgBU0VNSpISKHPAK1FpYI9BlH8Vh/9crGj7lCA0LbYR1LnPXcTZKEx/qnFCu96ExU Mv6zCmsIQvxsaRVEhDxh2iw9yCTFIvdbP/1Uy74jtqOpzPKfbwvKtIPktEBvbYGekBlj rKDexFp1bX20Rtuz9WUnJO4JsYxaE8nMcMgiiGBFpIYowe5yTtX6qS6D/YPhRSuiDk71 brKy4QiHxXXu77m3HB7dTH1BlGpoD5FCpGDTXtmLM8ykywkh2Fg+SWY0sLIblBc3f3r2 JxA5VsS0igkS3pgmGhYG7UX008omGgia0fQZMj3/3Df6jS8PTuklB3ijLfcHiNXLN3sk 064Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CR24ckpewZdjYMNelax3MWbcJ+vLZz6wVxjwYah6JnI=; b=ohjZM4YDrnXVhsco0zQ2oNWne8WtmHi0/HnEnPOR9AMDf/U76JkZHxkGPpV16fV8nh ZJVB1Z7FO5VBawb7Ip6hWPrwM0L068Swhwtk2DNSh4VNGr6+ZCyhcM/scQ/4EJOsfjTD vP3AD7j6piLvt5dwsNyWXCFqW2SEJc5mLJnTKzbuFeGUdSnTBEIq/cSASvgtGI/502cf 145f7E978S9zum8IG/YImUgk3DVEpN0HiCLpcl+aWDsMQixWsN1FcNmEw3/VutVa+PPD 8OLus3WZ35LgeLJr9dQIlHnz9eTY5An/yAjZVYjfDT2i7GukLbPP85mGREOXMM0WRKyl tH+g== X-Gm-Message-State: APjAAAV0lsEsz5W+NFHPojDLEmxeBoH14tI3GhtqyNr325Yz+rWJx/z/ Maf+UYVAmypMoRWOpmBZpypFwcfXkvE3/WTl1mFucQ== X-Google-Smtp-Source: APXvYqzbMYjSiOje1Dpn764D5CrVbO6GMPOd8z1tNtgOFTRLxq6OMgU0lzMWMHHZtR2CgEfo58biGgKAGRwgCnC7+8k= X-Received: by 2002:ac8:68c:: with SMTP id f12mr2567110qth.187.1576351690506; Sat, 14 Dec 2019 11:28:10 -0800 (PST) MIME-Version: 1.0 References: <201912140828.xBE8SAXq027656@repo.freebsd.org> <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org> In-Reply-To: <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org> From: Warner Losh Date: Sat, 14 Dec 2019 12:27:59 -0700 Message-ID: Subject: Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo To: Pedro Giffuni Cc: Ryan Libby , Conrad Meyer , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47ZyHd0ly2z4flp X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=jBgBU0VN; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::832) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.70 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.70)[ip: (-9.36), ipnet: 2607:f8b0::/32(-2.20), asn: 15169(-1.91), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_CC(0.00)[gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2019 19:28:14 -0000 On Sat, Dec 14, 2019 at 12:22 PM Pedro Giffuni wrote: > > On 14/12/2019 13:20, Ryan Libby wrote: > > On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer wrote: > >> Author: cem > >> Date: Sat Dec 14 08:28:10 2019 > >> New Revision: 355747 > >> URL: https://svnweb.freebsd.org/changeset/base/355747 > >> > >> Log: > >> Deprecate sranddev(3) API > >> > >> It serves no useful purpose and wasn't as popular as its equally > meritless > >> cousin, srandomdev(3). > >> > >> .. (cut unrelated code) > >> > >> Modified: head/include/stdlib.h > >> > ============================================================================== > >> --- head/include/stdlib.h Sat Dec 14 05:21:56 2019 > (r355746) > >> +++ head/include/stdlib.h Sat Dec 14 08:28:10 2019 > (r355747) > >> @@ -309,12 +309,17 @@ int rpmatch(const char *); > >> void setprogname(const char *); > >> int sradixsort(const unsigned char **, int, const unsigned char *, > >> unsigned); > >> -void sranddev(void); > >> void srandomdev(void); > >> long long > >> strtonum(const char *, long long, long long, const char **); > >> > >> /* Deprecated interfaces, to be removed. */ > >> +static inline void > >> +__attribute__((__deprecated__("sranddev to be removed in FreeBSD 13"))) > >> +sranddev(void) > >> +{ > >> +} > >> + > > This broke some gcc builds in ci. It looks like older versions of gcc > > don't like having an argument to deprecated. > > FWIW, the msg argument for __deprecated__ appeared in GCC 4.5. > Maybe sys/cdefs.h should define a __DEPRECATED for such differences? It's not like __attribute__ is a standard thing anyway... Warner