Date: Thu, 8 Feb 2018 01:19:31 -0600 From: Mark Linimon <linimon@lonesome.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Ganael LAPLANCHE <martymac@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r460940 - in head/games: afternoonstalker burgerspace cosmosmash Message-ID: <20180208071931.GA13039@lonesome.com> In-Reply-To: <20180208071352.GA63012@FreeBSD.org> References: <201802041634.w14GYHVW017651@repo.freebsd.org> <20180208071352.GA63012@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 08, 2018 at 07:13:52AM +0000, Alexey Dokuchaev wrote: > On Sun, Feb 04, 2018 at 04:34:17PM +0000, Ganael LAPLANCHE wrote: > > New Revision: 460940 > > URL: https://svnweb.freebsd.org/changeset/ports/460940 > > > > Log: > > Fix build with Clang 6 (C++14 by default) > > ... by forcing gnu++98 without giving the details of the breakages and > why they were not properly fixed instead. :-) For once I'm going to agree with danfe (someone take a picture!) but only to the extent that I would like to ask that the commit messages be "work around the build" rather than "fix". There have been numerous commits that did contain actual code fixes. Despite the quibble, I appreciate the effort people are putting into the clang 6 problems -- these have especially regressed our tier-2 package builds. mcl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180208071931.GA13039>