From owner-freebsd-current Tue Nov 28 13:57:50 2000 Delivered-To: freebsd-current@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id DC27B37B400; Tue, 28 Nov 2000 13:57:47 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id eASLvkQ62978; Tue, 28 Nov 2000 14:57:46 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id OAA13412; Tue, 28 Nov 2000 14:57:45 -0700 (MST) Message-Id: <200011282157.OAA13412@harmony.village.org> To: Kris Kennaway Subject: Re: wall/rwall cleanups Cc: current@FreeBSD.ORG In-reply-to: Your message of "Sat, 25 Nov 2000 21:59:13 PST." <20001125215912.A15309@citusc17.usc.edu> References: <20001125215912.A15309@citusc17.usc.edu> Date: Tue, 28 Nov 2000 14:57:45 -0700 From: Warner Losh Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20001125215912.A15309@citusc17.usc.edu> Kris Kennaway writes: : Please review. This syncs up our code with some NetBSD changes, as well : as attempting to sync rwall up with wall. You might also want to bruing in the openBSD changes for wall -g. Plus a few nits: + char *tty, hostname[MAXHOSTNAMELEN], lbuf[256], tmpname[64]; tmpname should be tmpname[MAXPATHLEN] since it is a path. Note well, not MAXPATHLEN + 1 since MAXPATHLEN is defined to include the trailing NUL (I have patches in my tree that fix this for the rest of the tree, at least the +1 issue, other issues will have to wait until I can audit all strings passed to open, mktemp, et al). Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message