From owner-freebsd-testing@FreeBSD.ORG Mon Oct 6 00:36:36 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 271E3815 for ; Mon, 6 Oct 2014 00:36:36 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E97F8172 for ; Mon, 6 Oct 2014 00:36:35 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s960aZ2o070353 for ; Mon, 6 Oct 2014 00:36:35 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 193499] [tests] usr.bin/yacc/err_syntax27.error failures with the latest kyua Date: Mon, 06 Oct 2014 00:36:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dickey@his.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 00:36:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193499 dickey@his.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dickey@his.com --- Comment #9 from dickey@his.com --- I made a different change on Thursday, using calloc to allocate the line data. That's overkill. At the same time, I had promised to make %parse-param work with %destructor, and had started that. So I've been working on this (and aside from retesting, static analysis) and "done". However, I took a look at this change (undoing the calloc), and it did not (for whatever reason) entirely fix the valgrind warnings. In my current code, I got this (with btyacc_demo.y): ==11640== 2 errors in context 1 of 2: ==11640== Invalid write of size 1 ==11640== at 0x4095DB: get_line (reader.c:137) ==11640== by 0x4097B6: nextc (reader.c:261) ==11640== by 0x40B04A: copy_destructor (reader.c:2703) ==11640== by 0x40BDEA: read_declarations (reader.c:1564) ==11640== by 0x40DF64: reader (reader.c:3433) ==11640== by 0x404BBE: main (main.c:692) ==11640== Address 0x518e7b5 is 0 bytes after a block of size 101 alloc'd ==11640== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==11640== by 0x4095A9: get_line (reader.c:128) ==11640== by 0x409664: next_inline (reader.c:215) ==11640== by 0x409759: nextc (reader.c:258) ==11640== by 0x40B28A: read_declarations (reader.c:1502) ==11640== by 0x40DF64: reader (reader.c:3433) ==11640== by 0x404BBE: main (main.c:692) I did use valgrind to spot the problem in err_syntax27.y, so we're talking about the same original report. Anyway, since I have a working fix, I'll continue with that. (thanks for the feedback) -- You are receiving this mail because: You are the assignee for the bug.