From nobody Wed Jul 29 18:38:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h9Lgw5rgkz6mfNb for ; Wed, 29 Jul 2026 18:38:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h9Lgw55rwz3Lgh for ; Wed, 29 Jul 2026 18:38:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785350316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uFyGNdEL1zlGyQ6XXJDrEWUpelzTBOk9ZUi36DJFSmM=; b=Ab8oLQiGbp9c5+mhApR1lpwxjoWNQOrjN3ZjtLYzFwJPL/lSMdZX3lJhAIU1xHhQQEegDP l8cdrTep3U3/oiUDZYECOD5e2lizJf9jOuS+e7HbwyQ/Z7DuHZwikUb/LIOWml7YQXlhlS 0ug3XKvM4aZybqqUJ0zNOmFHS8bvMcS3Bjn2jKG23C2CWC6qYgGqs7is8BDcjZxmOtDjqu /OTuBXZXvJMeEedEFj4KxARE60mxIVnTQpgFhVDRMfkjfc/iSlltKcXM6sRe/lm8yXnzfQ IssQAVfUIzkatKCqZy8dZlOCAykNKeUt8IAxav1qlSRuJqaQ3E1zw/PejmgOIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785350316; a=rsa-sha256; cv=none; b=AFHZWe2SFDjptlPBSFB8Cy5q9DU7pfUbFZGLZJYZCPgGVmlW3LD98EQ8EqBJU7pwX4PiRS 7eEeN68d63kyvfPlXqgu4R7qhbLyyWwRHIqZ9uRI95uay8kdGSwwSbnifxAMDYQLpdx1/N pNQvTFZyhp3CLRsHxNxunOQbmpk81NnRz7sDXOTdeefA7JSlw0sAg1yCdfafagy5P2vTHW yrQC+H+DqYIxKjcm9ClrHhN2QOGjMVJTmoeF0GIt3ZfrhbKsEvYk36F2dt7s57XY2+ssIT oMGIV7aZAJnZMyW5ytfxbbcK5bPByGVBrwiEizXJcL/2L7d8lp4n0C867yFsVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785350316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uFyGNdEL1zlGyQ6XXJDrEWUpelzTBOk9ZUi36DJFSmM=; b=xzn0BiFd8N0TDT+aDTDD6dW0N/8pn4pDcViQzr3fafD8Hkn3+cphKg4qKbA3c1NGepQcNz 6avFqCgqcoiBlF4VjtNmuCPu+YHWFjdO/dYQZQjaT54it4LqS5FWVSMJC2M/R/151VlAlc 9EIwc4JtJq1PqfQGuKXZ8S9r1Im5EybFrNMg7hTef73S/uKjL67tC0HuOccCRGgM8IdbQs mQzFKYxv+O2lES89uxDJCyXI2wkWvPUhp6dc1OzhBTZwPbYWzXwrJeYvaHmMNPR9I5EFkk 2NHzAV2mjnODQztx/mKRupyeIJlMvkYGIqa0e40fVcwDNIWsWLMJ45TdNKoiqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h9Lgw43rvzfXJ for ; Wed, 29 Jul 2026 18:38:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40006 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Jul 2026 18:38:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: ec73badfbc2e - main - rtld: Remove write-only text_end local variable from map_object List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ec73badfbc2e08928d917924af491c07e1f39a09 Auto-Submitted: auto-generated Date: Wed, 29 Jul 2026 18:38:31 +0000 Message-Id: <6a6a48a7.40006.46c361da@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ec73badfbc2e08928d917924af491c07e1f39a09 commit ec73badfbc2e08928d917924af491c07e1f39a09 Author: John Baldwin AuthorDate: 2026-07-29 18:38:08 +0000 Commit: John Baldwin CommitDate: 2026-07-29 18:38:08 +0000 rtld: Remove write-only text_end local variable from map_object Reviewed by: kib Fixes: 561991144e42 ("Remove Obj_Entry textsize member.") Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D58522 --- libexec/rtld-elf/map_object.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/libexec/rtld-elf/map_object.c b/libexec/rtld-elf/map_object.c index 0b4e847f407e..6f8160e003d7 100644 --- a/libexec/rtld-elf/map_object.c +++ b/libexec/rtld-elf/map_object.c @@ -94,7 +94,6 @@ map_object(int fd, const char *path, const struct stat *sb, bool ismain) Elf_Addr note_end; char *note_map; size_t note_map_len; - Elf_Addr text_end; hdr = get_elf_header(fd, path, sb, &phdr); if (hdr == NULL) @@ -115,7 +114,6 @@ map_object(int fd, const char *path, const struct stat *sb, bool ismain) note_map_len = 0; segs = xcalloc(hdr->e_phnum, sizeof(segs[0])); stack_flags = PF_X | PF_R | PF_W; - text_end = 0; while (phdr < phlimit) { switch (phdr->p_type) { case PT_INTERP: @@ -130,11 +128,6 @@ map_object(int fd, const char *path, const struct stat *sb, bool ismain) path, nsegs); goto error; } - if ((segs[nsegs]->p_flags & PF_X) == PF_X) { - text_end = MAX(text_end, - rtld_round_page(segs[nsegs]->p_vaddr + - segs[nsegs]->p_memsz)); - } break; case PT_PHDR: