From owner-cvs-src@FreeBSD.ORG Mon May 21 18:46:40 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 63E9116A469 for ; Mon, 21 May 2007 18:46:40 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7]) by mx1.freebsd.org (Postfix) with SMTP id EC9DD13C480 for ; Mon, 21 May 2007 18:46:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 11551 invoked by uid 399); 21 May 2007 18:46:39 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 21 May 2007 18:46:39 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <4651E90D.8030001@FreeBSD.org> Date: Mon, 21 May 2007 11:46:37 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0b2 (X11/20070116) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200705211144.l4LBiEHY098477@repoman.freebsd.org> <4651E084.1020605@FreeBSD.org> <86zm3yghuf.fsf@dwp.des.no> In-Reply-To: <86zm3yghuf.fsf@dwp.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, "Ralf S. Engelschall" , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d hostid X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2007 18:46:40 -0000 Dag-Erling Smørgrav wrote: > Doug Barton writes: >> Meanwhile, I've attached a patch that simplifies the hostid_hardware() >> quite a bit, and has the added virtue of only calling csh if it's >> needed. > > It also fails to ensure that the UUID has the correct syntax. If we're really concerned that this could be a problem (and I don't know enough about it to comment) then feel free to wrap a syntax test around the last echo. What I'm trying to do is simplify the routine, and allow obviously bogus responses to be rejected with cheap tests. Given that this thing is on by default, and that people are always complaining that rc.d stuff runs too slow, we need to be a little more careful to do it well, rather than just good enough. Doug -- This .signature sanitized for your protection