From owner-freebsd-fs@FreeBSD.ORG Wed May 15 15:18:40 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1038217B for ; Wed, 15 May 2013 15:18:40 +0000 (UTC) (envelope-from ajit.jain@cloudbyte.com) Received: from mail-ob0-x236.google.com (mail-ob0-x236.google.com [IPv6:2607:f8b0:4003:c01::236]) by mx1.freebsd.org (Postfix) with ESMTP id CDF5D6A4 for ; Wed, 15 May 2013 15:18:39 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id va2so2140174obc.13 for ; Wed, 15 May 2013 08:18:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=57Z8h9PleFS+o3uO39AgMeT6IvZ/Flx2H4lHKFwy2to=; b=kVlnwsyfN840DgYCHJDz1FDpQZgMbWCPno7hSwkCNYNTSAnIBimcUgUJu7g7RhzxQJ q9rGiA4ZQG2RsFk04PUO2wG593Hck4hOJ727iQbfls86CqhZ7lIAiWMzW6lgKgPlQXYl nOW/cbb5F3IpgrgMWSX+a1nSiF2XkivYo4P4wmBJJn8BN7imKmPsgwKYPWnMfKWYn2V/ hNVRLhWx1a+NlXyiUXLbbUo9l/v8Re7u/bqVf/3N1sFMyfYIdNL6KuNEK0v4bw3djG7k /Gx7z1Om9k4Ti9+kQSYwKo7cK7m8cLJdpx1v7inYmgZQtdSsDGFo6MLcAKU23VDsQjdN t9Tw== X-Received: by 10.182.225.199 with SMTP id rm7mr4040607obc.20.1368631119300; Wed, 15 May 2013 08:18:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.151.134 with HTTP; Wed, 15 May 2013 08:18:19 -0700 (PDT) In-Reply-To: <3E9CA9334E6F433A8F135ACD5C237340@multiplay.co.uk> References: <60316751643743738AB83DABC6A5934B@multiplay.co.uk> <20130429105143.GA1492@icarus.home.lan> <3AD1AB31003D49B2BF2EA7DD411B38A2@multiplay.co.uk> <9681E07546D348168052D4FC5365B4CD@multiplay.co.uk> <3E9CA9334E6F433A8F135ACD5C237340@multiplay.co.uk> From: Ajit Jain Date: Wed, 15 May 2013 20:48:19 +0530 Message-ID: Subject: Re: seeing data corruption with zfs trim functionality To: Steven Hartland X-Gm-Message-State: ALoCoQmW40N4Da434peRebl26MKlIPNf7834b/FcdBEEKKj2FZTIQF4GQC4abARLYhD2nn6uOW6K Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-fs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2013 15:18:40 -0000 Hi Steven, Thanks for the update. It is surprising that there is no/less disk activity as the command is correct. May be we need to enable sync=always on the zfs dataset. I will try again the once I update the cam code base. regards, ajit On Wed, May 15, 2013 at 7:37 PM, Steven Hartland wrote: > Unless you have the latest CAM patches, which is in current, you wont be > doing TRIM on SATA disk connected to an LSI controller. > > I've just tested using the following cmd under 8.3 with MFC'ed changes from > current, using ATA_TRIM, UNMAP & WS16 and have had no issues on a machine > with Intel SSD and LSI controller. > ./iotest -t 20 -s 536870912 -W 100 -T 500 /test/iotest/ > > I did however notice that your test is hardly doing any disk access apart > from when its "Initializing test file....", instead it seems to be CPU > bound, > so not sure if there's a problem with the iotest code or with my command > line args? > > Given this my current thinking is either: > 1. There's a problem with your patches 2. There's a bug in the FW of the > Seagate disk > 3. There's a problem with the UNMAP code which is being trigged by your > disk > only. > > I think #3 is quite unlikely. > > If you could install a recent version of current and test with that it > should rule out #1, leaving #2. > > > Regards > Steve > > ----- Original Message ----- From: "Ajit Jain" > > > Hi Steve, >> >> One more thing I am not seeing data corruption with SATA SSD (kingston). >> The issue was seen on SAS SSD i.e. Seagate PULSAR ST100FM0002 . >> >> regards, >> ajit >> >> >> On Wed, May 15, 2013 at 1:49 PM, Ajit Jain >> wrote: >> >> Hi Steven, >>> >>> Please find the tar ball of src code and binary of the test utility >>> attached with the mail. >>> Steps of test: >>> 1. Enable zfs trim in /boot/loader.conf (vfs.zfs.trim_disable=0) >>> 2. Set the delete method of the ssd device as UNMAP or WS16. >>> 3. Create a pool (and optionally dataset) on the device. >>> 4. Run iotest utility with thread count 10 (-t option) file size as at >>> least 5GB >>> Second to execute as at least 500 sec (-T option) and write as 100% >>> (W >>> option). >>> >>> regards, >>> ajit >>> >>> >>> On Wed, May 15, 2013 at 12:56 PM, Steven Hartland < >>> killing@multiplay.co.uk >>> > wrote: >>> >>> Could you provide us with details on the tests your using so we can >>>> run them here on current sources and see if we see any issues? >>>> >>>> Regards >>>> Steve >>>> >>>> ----- Original Message ----- From: "Ajit Jain" >>> > >>>> To: "Steven Hartland" >>>> Cc: "freebsd-fs" >>>> Sent: Wednesday, May 15, 2013 6:47 AM >>>> >>>> Subject: Re: seeing data corruption with zfs trim functionality >>>> >>>> >>>> Hi Steven, >>>> >>>>> >>>>> Thanks for the follow-up. >>>>> The code where I pulled in zfs trim patches is not updated to 9 stable >>>>> specially the cam directory. >>>>> I pulled in many dependent patches in order to apply the patches that >>>>> you >>>>> gave. After that all da devices >>>>> CAM_PERIPH_INVALID in dadone() because read capability was returning a >>>>> very >>>>> big number (bigger than MAXPHYS) >>>>> for the block size. I think this is because I have not update the code >>>>> to 9 >>>>> stable (only pulled in required patches and miss >>>>> some patches). >>>>> >>>>> So, I am planning to first update my code to 9stable and then try the >>>>> same >>>>> test again. That might take some time. >>>>> >>>>> >>>>> thanks again, >>>>> ajit >>>>> >>>>> >>>>> On Wed, May 15, 2013 at 2:40 AM, Steven Hartland < >>>>> killing@multiplay.co.uk>****wrote: >>>>> >>>>> >>>>> ----- Original Message ----- From: "Steven Hartland" >>>>> >>>>>> >>>>>> What version are you porting the changes to? >>>>>> >>>>>> >>>>>>> What SSD are you using? >>>>>>>>> >>>>>>>>> What LSI controller are you using? >>>>>>>>> >>>>>>>>> >>>>>>>>> I'd also like to see "zpool status" (for every pool that involves >>>>>>>> this >>>>>>>> SSD) and "gpart show" against the disk itself. >>>>>>>> >>>>>>>> >>>>>>>> Also: >>>>>>> 1. What FW version is your LSI? You can get this from dmesg. >>>>>>> 2. The exact command line your running iotest with? >>>>>>> >>>>>>> >>>>>>> Any update on this? I'd like to try and replicate your test here so >>>>>> would appreciate as much information as possible. >>>>>> >>>>>> >>>>>> Regards >>>>>> Steve >>>>>> >>>>>> ==============================******================== >>>>>> >>>>>> >>>>>> This e.mail is private and confidential between Multiplay (UK) Ltd. >>>>>> and >>>>>> the person or entity to whom it is addressed. In the event of >>>>>> misdirection, >>>>>> the recipient is prohibited from using, copying, printing or otherwise >>>>>> disseminating it or any information contained in it. >>>>>> In the event of misdirection, illegible or incomplete transmission >>>>>> please >>>>>> telephone +44 845 868 1337 >>>>>> or return the E.mail to postmaster@multiplay.co.uk. >>>>>> >>>>>> >>>>>> >>>>>> >>>>> ==============================****================== >>>> This e.mail is private and confidential between Multiplay (UK) Ltd. and >>>> the person or entity to whom it is addressed. In the event of >>>> misdirection, >>>> the recipient is prohibited from using, copying, printing or otherwise >>>> disseminating it or any information contained in it. >>>> In the event of misdirection, illegible or incomplete transmission >>>> please >>>> telephone +44 845 868 1337 >>>> or return the E.mail to postmaster@multiplay.co.uk. >>>> >>>> >>>> >>> >> > ==============================**================== > This e.mail is private and confidential between Multiplay (UK) Ltd. and > the person or entity to whom it is addressed. In the event of misdirection, > the recipient is prohibited from using, copying, printing or otherwise > disseminating it or any information contained in it. > In the event of misdirection, illegible or incomplete transmission please > telephone +44 845 868 1337 > or return the E.mail to postmaster@multiplay.co.uk. > >