From owner-freebsd-hackers@FreeBSD.ORG Fri Jun 11 14:26:16 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7711B16A4CE for ; Fri, 11 Jun 2004 14:26:16 +0000 (GMT) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 653EC43D2D for ; Fri, 11 Jun 2004 14:26:16 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i5BEQFgd097584; Fri, 11 Jun 2004 07:26:15 -0700 (PDT) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i5BEQF4c097583; Fri, 11 Jun 2004 07:26:15 -0700 (PDT) (envelope-from rizzo) Date: Fri, 11 Jun 2004 07:26:15 -0700 From: Luigi Rizzo To: Jens Schweikhardt Message-ID: <20040611072615.A96657@xorpc.icir.org> References: <20040611025307.GG17367@teleri.net> <20040611140740.GA3355@schweikhardt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20040611140740.GA3355@schweikhardt.net>; from schweikh@schweikhardt.net on Fri, Jun 11, 2004 at 04:07:40PM +0200 cc: Chip Norkus cc: hackers@freebsd.org Subject: Re: indent bugfix / added features X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 14:26:16 -0000 On Fri, Jun 11, 2004 at 04:07:40PM +0200, Jens Schweikhardt wrote: > On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote: ... > # normalize the code a bit. In doing so I discovered a few deficencies in > # the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I > # thought these might be fairly common wishes (and one of them is a > # bugfix) and have attached a patch which does the following: ... > # I don't know if anyone would be interested in committing the bugfix (I > # believe it is correct) or added features, but I hope someone else finds > # this useful. ... > I'm willing to commit this if you could demonstrate that it will not > produce different output in the default case than it does now. Say, > run the old an new versions against the FreeBSD src tree and make a diff > which should vanish apart from the bug-fixing effects. If you want to > make yourself known as a quality software engineer, do the same for > various sets of indent options :-) ?? this sounds like an absurd request, please... First, for a small patch like this you are much better off looking at the source code diffs rather than checking the output in a necessarily small set of test cases. Second, either you trust the author (in which case his statement "I believe is correct" is all you need), or you don't, in which case you'd have to check the patch yourself in whatever way you believe suitable. Either way, I don't see how the additional tests you are asking for would change your behaviour. cheers luigi