From nobody Thu Feb 2 07:39:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6rKB51bvz3c8yX; Thu, 2 Feb 2023 07:39:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6rKB3rMCz3Cr6; Thu, 2 Feb 2023 07:39:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675323582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sSIhZf8vA0Gzv/llKUVifPjd04rRxOzd8wl96Lz5kBM=; b=f/JTdvzfR26cNFN+XCQ+DUmWGYj3X+XccawHFQImosX3dd+oVEHBjSwgcNLrFI7wtTbfel GZPAuAkADukQ5e2Lw95o/+RK0nLp665QV4uMksB1KJWVIZpQjvq5m91NM4/atlxoZxFRxO Tnoh9oYV80bVEDVT8RMRDb6vCIRKmCHyOE4v6DCzxlJPrPtIprx5sE3BBsknxqy64Bliq7 2RzjM5HTtbOk7nkE3yAvY223mGEkWBDq/Qp+AeyP0ejf7++bnk/cu9ZAcRxS0cm1iBNv2U Mje3SAHaqBU3gtp3LBa89WIH1eOrSazocY/atYBlp1ro+IYJeOdA7STfWPalsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675323582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sSIhZf8vA0Gzv/llKUVifPjd04rRxOzd8wl96Lz5kBM=; b=n+csz0cKq4x4B3bnpoUcmIZKw40/Acx3jvkIlAc0Ro7f9D7EdxhUDVlR5s1PeZwRITPnKk N7ikNGN8sVU+hr27o6Rrwlq8am6MMxYTbHAT6pl7yAYQQlXNsw7vYO++v+6+poOEaNk3Yk N3kKLHxERf57KOMCllLRAezPEYG8i1H8L5u3j5A+Y6/d0X/clAJoqAdkvEdzP/ikh4TA1w CAS+94LmeFQsdqqDO+RVjNVHpIRMh1eEjmtfTiN9eunqqnxR9SPnahowPCQvJjZnuOQxsE dLsGQ1qWzv7MVuZKcGYbvkmLJhETWYkJWkb/CcvTzR0OzmBmvubnNhkhhtaL6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675323582; a=rsa-sha256; cv=none; b=sCDMz7e2FSuunx+Q64IFcsiHbNy6C4dQO1juGmKXCwn0BptV/g5e7t2tVEG/EiY2HLUoda 5W8Nvw1UYGhsjyyaR9kt/cWDJSaHYxfbpaxUobDu/InBv/ld/ENtbUbDDDdOgHGvTNqubn BNOQNc/IQziubACf9Dskxxae6sK84xFJL6yitYtZdq8rKqyiO4ErSvRpqLOFa6aAAKBULK mnw4bZrUPiJVivrAadRyQW2n6tLBMZ+SgiA468vNFw9u/AsCa6lQhRJSZgrvlK+CfVKKAe tQj8u47ZaaEqoesmjoCYb3YOQl6fpuAdFlhsRzNG4aiyv3QaCCUqW2D/rIIi1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P6rKB2xRTzmDp; Thu, 2 Feb 2023 07:39:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3127dgq2062262; Thu, 2 Feb 2023 07:39:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3127dgUf062261; Thu, 2 Feb 2023 07:39:42 GMT (envelope-from git) Date: Thu, 2 Feb 2023 07:39:42 GMT Message-Id: <202302020739.3127dgUf062261@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 0d15ab14a4f4 - stable/13 - cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 0d15ab14a4f48044eb91b356ae7c863228790702 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=0d15ab14a4f48044eb91b356ae7c863228790702 commit 0d15ab14a4f48044eb91b356ae7c863228790702 Author: Navdeep Parhar AuthorDate: 2022-10-05 18:05:12 +0000 Commit: Navdeep Parhar CommitDate: 2023-02-02 07:20:15 +0000 cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask. This was added in 7cba15b16eb2 in 2016 and firmwares at that time were already setting up the iSCSI tag mask properly. Since then it has also become possible to split the iSCSI region between multiple PCIE PFs but the driver's calculation takes only its own PF's allocation into account and that means this code is incorrect and not just a harmless no-op. Sponsored by: Chelsio Communications (cherry picked from commit 661faa1f77c0fa9d28d60d71087820aaaaee8b1b) --- sys/dev/cxgbe/cxgbei/cxgbei.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/sys/dev/cxgbe/cxgbei/cxgbei.c b/sys/dev/cxgbe/cxgbei/cxgbei.c index ad66247775e1..b6dc5d5c3577 100644 --- a/sys/dev/cxgbe/cxgbei/cxgbei.c +++ b/sys/dev/cxgbe/cxgbei/cxgbei.c @@ -167,21 +167,6 @@ cxgbei_init(struct adapter *sc, struct cxgbei_data *ci) return (rc); } - r = t4_read_reg(sc, A_ULP_RX_ISCSI_TAGMASK); - r &= V_ISCSITAGMASK(M_ISCSITAGMASK); - if (r != pr->pr_tag_mask) { - /* - * Recent firmwares are supposed to set up the iSCSI tagmask - * but we'll do it ourselves it the computed value doesn't match - * what's in the register. - */ - device_printf(sc->dev, - "tagmask 0x%08x does not match computed mask 0x%08x.\n", r, - pr->pr_tag_mask); - t4_set_reg_field(sc, A_ULP_RX_ISCSI_TAGMASK, - V_ISCSITAGMASK(M_ISCSITAGMASK), pr->pr_tag_mask); - } - read_pdu_limits(sc, &ci->max_tx_data_len, &ci->max_rx_data_len, pr); sysctl_ctx_init(&ci->ctx);