From owner-freebsd-arch Wed Nov 6 15:15:10 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6DB8937B401 for ; Wed, 6 Nov 2002 15:15:09 -0800 (PST) Received: from kayak.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0EC543E42 for ; Wed, 6 Nov 2002 15:15:08 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by kayak.xcllnt.net (8.12.6/8.12.6) with ESMTP id gA6NF80N003806 for ; Wed, 6 Nov 2002 15:15:08 -0800 (PST) (envelope-from marcel@kayak.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.6/8.12.6) with ESMTP id gA6NFIvY001597 for ; Wed, 6 Nov 2002 15:15:18 -0800 (PST) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.6/8.12.6/Submit) id gA6NFI0A001596 for arch@FreeBSD.org; Wed, 6 Nov 2002 15:15:18 -0800 (PST) Date: Wed, 6 Nov 2002 15:15:18 -0800 From: Marcel Moolenaar To: arch@FreeBSD.org Subject: Suggestion: modules: ARCHS variable in makefiles Message-ID: <20021106231518.GA1505@dhcp01.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.1i Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Gang, Johns sweep over the drivers to clean up some warnings triggered a thought in me. But enough about that, what about the following: :-) The way we define SUBDIR in src/sys/modules/Makefile has annoyed me enough that I'm willing to spend a not-completely-unlimited time to handle it roughly the same as we do for ports: The makefile for a module lists the architectures it's supposed to work on and is simply skipped if the current (target) architecture is not in the list. The top-level modules Makefile simply lists *all* modules, possibly adjusted by some unrelated knob (such as WANT_EXT2FS_MODULE or NO_IPFILTER). Pros: 1. sys/modules/Makefile will be much cleaner with less duplication. 2. Modules can more easily be build in alphabetical order (ie without making the makefile unreadable). 3. More control for the module specific makefile (localized history). 4. Less tweaking in the top-level makefile when new architectures are being introduced. Cons: 1. Build-time overhead to recurse all modules, including the ones that aren't being built. 2. More work to enable true MI modules (assuming opt-in only) Q: Do people think it's a good approach (ie worth to spend time on)? Q: Is this something that may benefit 5.0-RELEASE or is it something that can better wait (ie spend time now on)? Just a thought, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message