Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jul 2017 12:01:51 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Richard Gallamore <ultima@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r445123 - in head/net-mgmt/ccnet-client: . files
Message-ID:  <20170707120151.GA57983@FreeBSD.org>
In-Reply-To: <201707060221.v662LNM1037673@repo.freebsd.org>
References:  <201707060221.v662LNM1037673@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 06, 2017 at 02:21:23AM +0000, Richard Gallamore wrote:
> New Revision: 445123
> URL: https://svnweb.freebsd.org/changeset/ports/445123
> 
> Log:
>   * Add patch to fix build for libressl
>   * Removed --enable-ldap, not a valid configure arg
>   
> [...]
> @@ -21,19 +22,17 @@ LIB_DEPENDS=	libsearpc.so:devel/libsearpc \
>  
>  CONFLICTS=	ccnet-server-[0-9]*
>  
> -USE_GITHUB=	yes
> -GH_ACCOUNT=	haiwen
> -GH_PROJECT=	ccnet
> -
>  USES=		autoreconf gettext libtool localbase pathfix pkgconfig \
>  		python:-2.7 ssl
>  USE_GNOME=	glib20
>  USE_LDCONFIG=	yes
>  USE_OPENLDAP=	yes
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	haiwen
> +GH_PROJECT=	ccnet

Please try to avoid these gratuitous changes.  GitHub-related knobs are
often grouped together and put closer to the top because they are more
related to obtaining the distfile (think MASTER_SITES) rather than the
configuring/building/etc. steps of software itself.

In any case, this move should've been reflected in the commit log with
proper explanation.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170707120151.GA57983>