From owner-freebsd-ports  Mon Nov 27 12:10: 6 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id BE21637B4CF
	for <freebsd-ports@FreeBSD.org>; Mon, 27 Nov 2000 12:10:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id MAA58194;
	Mon, 27 Nov 2000 12:10:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from wooster.jumpdata.com (flimsy.lean.to [166.90.128.243])
	by hub.freebsd.org (Postfix) with ESMTP id 437FE37B479
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Nov 2000 12:04:52 -0800 (PST)
Received: (from anand@localhost)
	by wooster.jumpdata.com (8.11.1/8.11.1) id eARK58H44833;
	Mon, 27 Nov 2000 12:05:08 -0800 (PST)
	(envelope-from anand)
Message-Id: <200011272005.eARK58H44833@wooster.jumpdata.com>
Date: Mon, 27 Nov 2000 12:05:08 -0800 (PST)
From: Anand Ranganathan <anand@desktop.com>
Reply-To: anand@desktop.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/23139: Additional patch for gnomecontrolcenter port.
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         23139
>Category:       ports
>Synopsis:       Additional patch for gnomecontrolcenter port.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 27 12:10:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Anand Ranganathan
>Release:        FreeBSD 4.2-RELEASE i386
>Organization:
>Environment:

FreeBSD 4.2-RELEASE, i386, gnomecontrolcenter port in 
/usr/ports/sysutils/gnomecontrolcenter. Also the package
gnomecontrolcenter-1.2.2.
	

>Description:

	The gtk theme switcher applet dies with SEGV when the user attempts
to change the gtk theme.

>How-To-Repeat:

	Start up the theme selector app with the command:
theme-selector-capplet. This can also be started by starting the gnomecc
app, and then selecting "Theme Selector" in the left hand menu under the
"Desktop" menu item. In the "Available Themes" list, choose a different
theme than the one currently in use. The applet should dump core
immediately. This is also referenced in a gnome bug filed by some one
else:
http://bugs.gnome.org/db/26/26809.html


>Fix:

	Add this patch to the list of patches currently used when building
the port. I considered sending the port to gnome, but it looks like the
next release of this software will use a radically different codebase, so
this will be unnecessary when that happens.

--- capplets/theme-switcher/lister.c.orig	Mon Nov 27 11:39:55 2000
+++ capplets/theme-switcher/lister.c	Mon Nov 27 11:18:25 2000
@@ -160,6 +160,8 @@
       while (!feof (fin))
 	{
 	  getline (&lineptr, &linecount, fin);
+          if (feof(fin))
+            break;
 	  if (ferror(fin))
 	    {
 	      errstring = g_strdup_printf ("Error reading from RC file %s: %s",


>Release-Note:
>Audit-Trail:
>Unformatted:
 Anand Ranganathan


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message