From owner-freebsd-bugs@freebsd.org  Wed Jul 15 07:24:48 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A3CB9A2F78
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed, 15 Jul 2015 07:24:48 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4547D157C
 for <freebsd-bugs@FreeBSD.org>; Wed, 15 Jul 2015 07:24:48 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6F7Om7A071951
 for <freebsd-bugs@FreeBSD.org>; Wed, 15 Jul 2015 07:24:48 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 201582] ministat does not calculate proper median value (patch
 included)
Date: Wed, 15 Jul 2015 07:24:48 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: marcus@blazingdot.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 attachments.created
Message-ID: <bug-201582-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 07:24:48 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201582

            Bug ID: 201582
           Summary: ministat does not calculate proper median value (patch
                    included)
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: marcus@blazingdot.com

Created attachment 158793
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=158793&action=edit
Make ministat return proper value for median

>From http://www.mathgoodies.com/lessons/vol8/median.html :

"The median of a set of data is the middlemost number in the set. The median is
also the number that is halfway into the set. To find the median, the data
should be arranged in order from least to greatest. If there is an even number
of items in the data set, then the median is found by taking the mean (average)
of the two middlemost numbers."

Ministat currently returns the second of the two middle numbers if there is an
even number of entries.  This patch takes the middle two and returns their
average.

*** usr.bin/ministat/ministat.c.orig    2015-07-14 23:49:11.246171000 -0700
--- usr.bin/ministat/ministat.c    2015-07-15 00:16:20.895494000 -0700
***************
*** 193,199 ****
  Median(struct dataset *ds)
  {

!     return (ds->points[ds->n / 2]);
  }

  static double
--- 193,200 ----
  Median(struct dataset *ds)
  {

!     if(!(ds->n % 2)) return ((ds->points[ds->n / 2]) + (ds->points[(ds->n /
2)-1]))/2;
!     else return (ds->points[ds->n / 2]);
  }

  static double

-- 
You are receiving this mail because:
You are the assignee for the bug.