From owner-dev-commits-src-all@freebsd.org Sat Feb 6 18:30:37 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F5495311EF; Sat, 6 Feb 2021 18:30:37 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DY17K1ncQz3CKC; Sat, 6 Feb 2021 18:30:37 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 2B2851107; Sat, 6 Feb 2021 18:30:37 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f180.google.com with SMTP id h8so157481qkk.6; Sat, 06 Feb 2021 10:30:37 -0800 (PST) X-Gm-Message-State: AOAM531/vl1dGhbSRF9lgk7AqE9++r/jdddj+KQNxtd5O7tlQLzbEO9b L4Sd+do9wJlBI2o+vsbSJxBF+FUjbrMUit0yD+I= X-Google-Smtp-Source: ABdhPJzr0jmPVy+PgJElcFTHy+pLiB8G4YZu20aOLLLa1qdxsBnrrcC4j9E8jNWtAT2Z+zYhcvwmDbGihige2zWsujc= X-Received: by 2002:ae9:e80e:: with SMTP id a14mr390928qkg.103.1612636236740; Sat, 06 Feb 2021 10:30:36 -0800 (PST) MIME-Version: 1.0 References: <202102042333.114NXowE086993@gitrepo.freebsd.org> In-Reply-To: <202102042333.114NXowE086993@gitrepo.freebsd.org> From: Kyle Evans Date: Sat, 6 Feb 2021 12:30:19 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7d4dceec1030 - main - ixl(4): Fix VLAN HW filtering To: Eric Joyner , Krzysztof Galazka Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Feb 2021 18:30:37 -0000 On Thu, Feb 4, 2021 at 5:34 PM Eric Joyner wrote: > > The branch main has been updated by erj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > commit 7d4dceec103039e2b2fa90793ceeb71a8d6684aa > Author: Krzysztof Galazka > AuthorDate: 2021-02-03 23:22:55 +0000 > Commit: Eric Joyner > CommitDate: 2021-02-04 23:33:42 +0000 > > ixl(4): Fix VLAN HW filtering > > X700 family of controllers has limited number of available VLAN > HW filters. Driver did not handle properly a case when user > assigned more VLANs to the interface which had all filters > already in use. Fix that by disabling HW filtering when > it is impossible to create filters for all requested VLANs. > Keep track of registered VLANs using bitstring to be able > to re-enable HW filtering when number of requested VLANs > drops below the limit. > > Also switch all allocations to use M_IXL malloc type > to ease detecting memory leaks in the driver. > Hi, This adds a dependency on `device ixl` for `device iavf` since M_IXL is defined in ixl_pf_main.c, but I think that particular part should be partially reverted anyways. There's an M_IAVF already that's more appropriate for i40e_osdep.c -- proposed patch here: https://people.freebsd.org/~kevans/0001-ixl-switch-i40e_osdep.c-allocations-to-M_IAVF.patch Thanks, Kyle Evans