From owner-freebsd-net@freebsd.org Thu Nov 8 10:11:35 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C87591124552 for ; Thu, 8 Nov 2018 10:11:35 +0000 (UTC) (envelope-from oleg@lath.rinet.ru) Received: from lath.rinet.ru (lath.rinet.ru [195.54.192.90]) by mx1.freebsd.org (Postfix) with ESMTP id EACE8770CE for ; Thu, 8 Nov 2018 10:11:31 +0000 (UTC) (envelope-from oleg@lath.rinet.ru) Received: by lath.rinet.ru (Postfix, from userid 222) id 450C3A0CB; Thu, 8 Nov 2018 13:11:24 +0300 (MSK) Date: Thu, 8 Nov 2018 13:11:24 +0300 From: Oleg Bulyzhin To: freebsd-net@FreeBSD.org Subject: ix0 (iflib) vlans @ head & 12-stable Message-ID: <20181108101124.GB80723@lath.rinet.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: EACE8770CE X-Spamd-Result: default: False [2.80 / 200.00]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.94)[0.945,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[FreeBSD.org]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_MEDIUM(0.93)[0.927,0]; MX_GOOD(-0.01)[lath.rinet.ru]; NEURAL_SPAM_LONG(0.97)[0.973,0]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[oleg@FreeBSD.org,oleg@lath.rinet.ru]; RCVD_NO_TLS_LAST(0.10)[]; R_DKIM_NA(0.00)[]; IP_SCORE(0.77)[ipnet: 195.54.192.0/19(2.14), asn: 8331(1.71), country: RU(-0.02)]; ASN(0.00)[asn:8331, ipnet:195.54.192.0/19, country:RU]; FROM_NEQ_ENVFROM(0.00)[oleg@FreeBSD.org,oleg@lath.rinet.ru]; TO_DOM_EQ_FROM_DOM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 10:11:35 -0000 --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable While testing 12-stable i've found following: current ixgbe driver is using iflib and has IFCAP_VLAN_HWFILTER enabled by default. /sys/net/iflib.c iflib_vlan_[un]register() functions have this code: /* Re-init to load the changes */ if (if_getcapenable(ifp) & IFCAP_VLAN_HWFILTER) iflib_if_init_locked(ctx); Thus any vlan reconfiguration leads to link flap. This is not how it was before iflib conversion. I'm not sure about other vlanhwfilter aware hardware but=20 intel x520-da2 cards (82599 chip) does not require re-init after hwfilter reconfig. Should we extend iflib framework a bit? --=20 Oleg. --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRU3IiAS5hzxBjDaSalDfmDDe+xhwUCW+QLxQAKCRClDfmDDe+x hyyTAQCrE6c7zqXjGLT+5xUU5VQsueJyNY0nsHWUFOlHb67wgAD8DI80leULEJIg BnvhiGj76APp33JPa0+LIDOgisPVPws= =veyq -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g--