From owner-cvs-all@FreeBSD.ORG Sat Jul 29 19:39:04 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D94916A4DA; Sat, 29 Jul 2006 19:39:04 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5726043D67; Sat, 29 Jul 2006 19:39:04 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6TJd4YE037385; Sat, 29 Jul 2006 19:39:04 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6TJd4NJ037384; Sat, 29 Jul 2006 19:39:04 GMT (envelope-from marcel) Message-Id: <200607291939.k6TJd4NJ037384@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 29 Jul 2006 19:39:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jul 2006 19:39:04 -0000 marcel 2006-07-29 19:39:04 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Change maketempfile() to return a FILE* so as to eliminate the fopen() that immediately follows the only call to it. maketempfile() uses mkstemp(), so the temporary file has already been opened and using fopen() again just opens the file twice. This also fixes the invalid mode used on the fopen(). While here, assign NULL to fxref after fclose() because we test for fxref being !NULL to determine if we have the (temporary) hints file open. Revision Changes Path 1.12 +7 -6 src/usr.sbin/kldxref/kldxref.c