From owner-freebsd-ports@FreeBSD.ORG Mon Aug 7 21:08:34 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAFE216A4DD for ; Mon, 7 Aug 2006 21:08:33 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6524743D6D for ; Mon, 7 Aug 2006 21:08:25 +0000 (GMT) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net ([12.207.12.9]) by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP id <20060807210824m92002slije>; Mon, 7 Aug 2006 21:08:24 +0000 Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.6/8.13.6) with ESMTP id k77L8M9w085833; Mon, 7 Aug 2006 16:08:22 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.6/8.13.6/Submit) id k77L8K3U085832; Mon, 7 Aug 2006 16:08:20 -0500 (CDT) (envelope-from brooks) Date: Mon, 7 Aug 2006 16:08:20 -0500 From: Brooks Davis To: Kris Kennaway Message-ID: <20060807210820.GB85637@lor.one-eyed-alien.net> References: <14817321@bsam.ru> <20060807183724.GA47899@xor.obsecurity.org> <16560673@bsam.ru> <20060807201203.GA84762@lor.one-eyed-alien.net> <50488990@bsam.ru> <20060807210357.GA50058@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <20060807210357.GA50058@xor.obsecurity.org> User-Agent: Mutt/1.5.11 Cc: Boris Samorodov , Brooks Davis , freebsd-ports@freebsd.org Subject: Re: extract both bz2 and gz files from distfiles X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2006 21:08:34 -0000 --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 07, 2006 at 05:03:57PM -0400, Kris Kennaway wrote: > On Tue, Aug 08, 2006 at 12:24:49AM +0400, Boris Samorodov wrote: > > On Mon, 7 Aug 2006 15:12:03 -0500 Brooks Davis wrote: > > > On Mon, Aug 07, 2006 at 11:56:46PM +0400, Boris Samorodov wrote: > > > > On Mon, 7 Aug 2006 14:37:25 -0400 Kris Kennaway wrote: > > > > > On Mon, Aug 07, 2006 at 03:12:06AM +0400, Boris Samorodov wrote: > > > >=20 > > > > > > We have got a port (lang/gnat-gcc34) which has both bz2 and gz > > > > > > distfiles. As for 5.x+ extracting is gone automagically. But no= t at > > > > > > 4.x. Well, at 4.x extracting may be done for example, by using > > > > > > USE_BZIP2 knob and doing gunzipping at after-extract:. > > > > > >=20 > > > > > > Does someone know a better solution? > > > > > > Does we have examples at our ports? > > > >=20 > > > > > Use a do-extract that extracts all distfiles or EXTRACT_ONLY with > > > > > post-extract that extracts the other ones. > > > >=20 > > > > Thanks, Kris. I'm trying to test (actually, to find an 4.x system) > > > > some broken ports with a patch(es) which includes (thanks Brooks): > > > > ----- > > > > .if ${OSVERSION} < 500000 > > > > EXTRACT_DEPENDS+=3D bsdtar:${PORTSDIR}/archivers/libarchive > > > > TAR=3D /usr/local/bin/bsdtar > > > > .endif > > > > ----- > > > >=20 > > > > To me that seems a good solution. > >=20 > > > I'd suggest using not using an absolute path in the TAR definition > > > since the dependency check doesn't and using 502111 as the version si= nce > > > that's the first version bump after the initial bsdtar import. Not t= hat > > > we really need to worry about such early 5.x release, but it's more > > > correct. > >=20 > > Thanks again, Brooks. The patch will include (if Kris won't complain): > > ----- > > .if ${OSVERSION} < 502111 > > EXTRACT_DEPENDS+=3D bsdtar:${PORTSDIR}/archivers/libarchive > > TAR=3D bsdtar > > .endif > > ----- >=20 > Actually I think you do need the absolute path, since it wont always > be set in the environment (think crontabs, etc). The correct > specification would be ${LOCALBASE}/bin/bsdtar. My thought was that the dependency check will fail if it's not in the path so there's no point in having the absolute path in the TAR part. -- Brooks --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFE16vDXY6L6fI4GtQRAt+SAKDLNZH7+L2H02Y6rvMn4w4YrkCqMACeJBnh LGJbWarEUrl/tO8twqUObao= =uCD/ -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ--