From owner-freebsd-net@FreeBSD.ORG  Sat Nov  3 20:53:03 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BB553120
 for <net@FreeBSD.org>; Sat,  3 Nov 2012 20:53:03 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id 336FE8FC0A
 for <net@FreeBSD.org>; Sat,  3 Nov 2012 20:53:02 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id qA3KqtPF066996;
 Sun, 4 Nov 2012 00:52:55 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id qA3KqsSh066995;
 Sun, 4 Nov 2012 00:52:54 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sun, 4 Nov 2012 00:52:54 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andre Oppermann <oppermann@networx.ch>
Subject: Re: splitting m_flags to pkthdr.flags + m_flags
Message-ID: <20121103205254.GX70741@glebius.int.ru>
References: <20121102123817.GP70741@FreeBSD.org> <5093C29A.4020902@networx.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <5093C29A.4020902@networx.ch>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: net@FreeBSD.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Nov 2012 20:53:03 -0000

On Fri, Nov 02, 2012 at 01:54:50PM +0100, Andre Oppermann wrote:
A> > An attentive reader may have noticed that I missed M_NOFREE and M_FREELIST.
A> > Yep, these flags coming from historical mbuf allocator from FreeBSD 4.x times
A> > are about to be deleted, we carefully examine them, but never set. Patch
A> > for review attached.
A> 
A> Looks good.  Go ahead from me.

History review reveals that M_NOFREE comes from r172463 by Kip Macy.
The idea was to have mbufs embdedded into clusters. The feature isn't
used by any module and isn't tested at all.

I ponder on should we leave the code as is or not?

M_FREELIST actually has nothing to do with historic mbuf allocator. It
was a bandaid that helped to debug double-frees. The code was washed
out from the repo, only the flag left. Also the functionality is now
available via generic allocator invariants. So M_FREELIST definitely
should be deleted.

But I'm not sure about M_NOFREE.

-- 
Totus tuus, Glebius.