From nobody Fri May 9 00:08:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ztq8W4lhnz5vpJG; Fri, 09 May 2025 00:08:11 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ztq8W38ycz459R; Fri, 09 May 2025 00:08:11 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746749291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZOc4Ageb0Iv2sKrTdzA69mQ37frF4KmZipBzLD37TY=; b=lWnIupRLPzQIcwmNYzdly2yb6vRnUkH60fue8k5MJhrAA4l3eNtothBChsny9b97P7O3ba +sOvdsboasL3FF282jqE/hPFkIiqfoF4xGyk8ZZxppL/axdVHp0mGXUq9PRyM7ocM8ObEm QGkksJtz2tQafnrEjWEU/5KlMNJbnaE6964vCWlfUkGKXQ6hbjybq23PJWG6clThPZGjoL V7jbYCNMzg8lUShR53s69FCi6sYZHgODeDjU9SixhSeAWdoc2C8SOkU7IuydY57DJFUHIw DVVm1bol/gfyN7gRjTZYlFXb3RIiWPHQkvW8iXXXlv0qwq/T4lLMoDVwMXRb8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746749291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZOc4Ageb0Iv2sKrTdzA69mQ37frF4KmZipBzLD37TY=; b=AGCeBcKn2Ug6tnh/W265CP3cEVeJj00eg2JgvftmCxSlEv/Bq9Yg02oz1EPfhdKJwnOr33 qb+bdFJSD2psWYnj28UopUQyBkVGq6mko+H8u7/+mg5m9hAIF2ObnQU4rZ3B17BoD+r8fP 3FTVWN5DuYKItyhdEBwDfK+DVRUdYtxmi3HzwpzjcCxQj03LB/0TgXw37UjM3vVDPr088p R8vp5Osr/TyiBiai4PR6IQGtlIDTBWjdlAta5eugiBES3u3VAPQ/gS0WTG2leWPYdnNZeL votdVBhUlmeUwt9GTRkoux+byQYcl0VKLv+9sJ0669nFf2nU/65yxzJpTvr55A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746749291; a=rsa-sha256; cv=none; b=dMKWjGShoT/4lkIl3uZwAvz0mjc/LBokxHqyB4unsPm8sekbxmuV0XuuDEBmmV5rV7o/mu tbZrkopcy1q3oP4/7L87n2ZUAfdnURj/1+Z0pGDqIPhql9nVurSVbcpPnevGyhK2g86Msq 3qBVPmhiOQxbIuRnleAQBQCogQq7H6cmtqMPVZUXsQk7IMkVuATd0RrAQuXLkS8X115Pfo CQ3hE6gfPq05MvRZrgn9P0HE7MHUDKG6Jw3t6qLvnf6MLMynegDwyAIChgJjU1Ag//Hjbd mG/8W3QijlGQ3bhbWIR8pEZB4CT/B3UXZQY6pD4ynhhUIwnBy0SXSyfzaWbvQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Ztq8V40JSz17Pq; Fri, 09 May 2025 00:08:10 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Thu, 8 May 2025 19:08:09 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 78661696e639 - main - loader: i386: use -z nostart-stop-gc for bfd as well To: Brooks Davis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202505081947.548JlM93086830@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/8/25 18:17, Brooks Davis wrote: > On Thu, May 08, 2025 at 07:47:22PM +0000, Kyle Evans wrote: >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=78661696e639836c9c41313020308f132057189a >> >> commit 78661696e639836c9c41313020308f132057189a >> Author: Kyle Evans >> AuthorDate: 2025-05-08 19:47:16 +0000 >> Commit: Kyle Evans >> CommitDate: 2025-05-08 19:47:16 +0000 >> >> loader: i386: use -z nostart-stop-gc for bfd as well >> >> binutils 2.37 seems to have added the knob, so let's just use that >> version here (it's not clear if GC'ing start/stop symbols was actually >> made the default at the time, and it didn't seem worth it to dig much >> further). This fixes misbehavior when built with more recent binutils, >> as we do rely on linker sets for loader commands that we use. > > Do we need the version guards any more? Even FreeBSD 12 has LLVM 13 and > binutils 2.37 is about to turn 4. > > -- Brooks Yeah, probably not. Jessica raised a valid point in the review that I had overlooked, though. Based on Simon's feedback, I did light investigation to determine where the options were introduced and just slapped it on for at least that, assuming it later became the default. Apparently it did not become the default, so it's not clear how Simon's build was different. OTOH, I'm not sure if that really changes anything (except that the mystery isn't fully solved)- if it's possible to configure such a bfd, IMO it doesn't hurt to use it since these sections/symbols being retained is critical. I don't see any reason not to drop the version bits. Ubuntu 22.04 seems to have binutils 2.38, so that's good at least -- I wasn't sure if the timing on 2.37 was right for that (or even what Ubuntu's policy is there). Thanks, Kyle Evans