From nobody Thu Oct 16 20:09:37 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cnfDx65xlz6D4hd for ; Thu, 16 Oct 2025 20:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cnfDx5LWmz3VwS for ; Thu, 16 Oct 2025 20:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760645377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dz5lFXGz1ejXfsipEOXgpDtohPUQAY9cKj6H4otDeug=; b=RAqWQ3t1cTDNSbFZE7XC/+va4rrdSbU5rQApZeXVXFcSim7E9zWWVZ4YzIOq47yrNVcKvJ LTp+KbwelbZEbJ86+Drn59+rBVPlJigNrmyVcQumVfJoTBz/+qM/gPXY3xKAzh/buhQeSu rMjGeaF3HTXQgOMNDYtaZ5sUXcTwaHm9YVVMBiYnG1ZtgU1BpVEAhytOvY1akEPUyHmMHK dPHjIqiQX05Ndt/n64lJJ0/mIcU5COp/sCbvTp83blIMjAHpWkXUasubISQ91kCeoUtsJ+ UvoX6/gha3ujoHg72HweGq5aBJKSv0GlsAEohy7Dn9rsyaecIrIint7ftytczA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760645377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dz5lFXGz1ejXfsipEOXgpDtohPUQAY9cKj6H4otDeug=; b=r5hqFigAzGDLoZrjlbh0HBdt1vVZEsIcioq6MbROLyp1CN4nxi6S+mI3P2kTOY+t74tg9s cDCaQz6afNVcfCPOCi/R1WLCvx39Y46UOj4r/EcS+LsgOHjQ/ey66r6yV87pa4E87e4Ii6 UMAwB9W2uy4kIwr9398A6ZuKTyabwQ5kq75lLTgiTgrrRHlYaYUD3VUS/5rs9WG3O7KLD+ je4sUZURelprqaBmdcElX4BpSjrmkAJNqU7OYYpro3qJhBzr+oBMU9nRRtF3NOGQ0c9sNh ziNUGgK9F4IEfw6qzexLR2A158SlijNL5TvytiHUGSnvc65iMVuWFoVf3N2znw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760645377; a=rsa-sha256; cv=none; b=ekJ4aWTiARBSWThyl6RQo7aV1YfeKbv7/PIqPWy9mGSsRBfgb0kpNp/t8oq0Vo9PnRo/zf jJS18rWXyG0pX3XURs0fm0fm9wxmTJXpuZsNvXGJ2BoLex+xwVCHUKWwUYcNWhUFrswmG4 F9KyfQHGswWU8ngvQ/w6vGnxcg9q9oiBDreY1p2gA+eon7kOoHvnGafdIwFP9L6zc/CWnx DSDSAg8G1EMXFnvg33+kWTPEfcMIucLfW9t6FvbzEcGldFXmoEDJcNndrlkq3dnL8FkcvU v53xddjHe8rsRKoChxIC0gOc970OAliTnHke7LUgl5YlTFiU7OWEICw+LgbI8g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cnfDx4YF2z6yF for ; Thu, 16 Oct 2025 20:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 59GK9bp5049749 for ; Thu, 16 Oct 2025 20:09:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 59GK9bvx049748 for net@FreeBSD.org; Thu, 16 Oct 2025 20:09:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283820] ixl multicast filter problems Date: Thu, 16 Oct 2025 20:09:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283820 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D46a8a1f08f88c278e60ebb6daa7a551eb= 641c67b commit 46a8a1f08f88c278e60ebb6daa7a551eb641c67b Author: Bhosale, Yogesh AuthorDate: 2025-10-16 20:02:45 +0000 Commit: Krzysztof Galazka CommitDate: 2025-10-16 20:04:01 +0000 ixl(4): fix multicast promiscuous mode state tracking and filter manage= ment This change reapplies the improvements from commit 89e7335 and adds additional fixes and code optimizations on top of it. The ixl driver supports up to 128 multicast filters in hardware. When t= his limit is exceeded, the driver should enable multicast promiscuous mode. When the count drops below 128, it should disable promiscuous mode and restore individual filters. The driver previously had problems that could corrupt multicast filters list. The main issue was that ixl_dis_multi_promisc() would attempt to disable promiscuous mode without checking if it was actually enabled, potential= ly corrupting existing filters. There was also no state tracking across dr= iver functions, leading to redundant operations. This change adds an IXL_FLAGS_MC_PROMISC flag to track the multicast promiscuous mode state. The flag is set when enabling promiscuous mode = and cleared when disabling it. Early return checks prevent redundant operat= ions when the mode is already in the desired state, avoiding filter corrupti= on and unnecessary hardware calls. Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com PR: 283820 Approved by: kbowling (mentor) Tested by: gowtham.kumar.ks_intel.com MFC after: 2 weeks Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D52549 sys/dev/ixl/if_ixl.c | 27 +++++++++++- sys/dev/ixl/ixl.h | 1 + sys/dev/ixl/ixl_pf_main.c | 110 +++++++++++++++++++++++++++++++++++++++---= ---- 3 files changed, 120 insertions(+), 18 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=