Date: Wed, 24 Nov 2010 12:53:09 +1300 From: Andrew Thompson <thompsa@FreeBSD.org> To: Hans Petter Selasky <hselasky@c2i.net> Cc: Weongyo Jeong <weongyo@freebsd.org>, freebsd-usb@freebsd.org Subject: Re: [RFC] USBdump patches Message-ID: <AANLkTike0MYAnaKkJzGHuZoUMyUy0HYRA_WzTc3ZAry4@mail.gmail.com> In-Reply-To: <201011232319.33678.hselasky@c2i.net> References: <AANLkTinaUNi3FGRiOkeTN2FKx3ybqE=F3W6%2BsV8qVCTf@mail.gmail.com> <AANLkTim15S-wOb-z2N7SHx2X%2Bty1qkdc3_Qz3q-PNsKY@mail.gmail.com> <20101123212448.GG92881@weongyo> <201011232319.33678.hselasky@c2i.net>
index | next in thread | previous in thread | raw e-mail
On 24 November 2010 11:19, Hans Petter Selasky <hselasky@c2i.net> wrote:
> Hi,
>
> Please find attached official usbdump patch from HPS trying to re-use as much
> as possible of Weongyo's code which was committed not long ago. You need to
> SVN up to the latest 9-current.
> @@ -270,7 +122,7 @@
> * The kernel needs to be able to verify an application's filter code.
> * Otherwise, a bogus program could easily crash the system.
> */
> -static int
> +static uint8_t
> usbpf_validate(const struct usbpf_insn *f, int len)
> {
Not related to the patch as a whole, but changing the return code of a
yes/no function from int to uint8_t doesn't save anything and I think
is less readable.
Andrew
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTike0MYAnaKkJzGHuZoUMyUy0HYRA_WzTc3ZAry4>