From owner-freebsd-geom@FreeBSD.ORG Thu Jun 16 09:40:08 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CECF9106564A for ; Thu, 16 Jun 2011 09:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BF5E78FC08 for ; Thu, 16 Jun 2011 09:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5G9e8cm005510 for ; Thu, 16 Jun 2011 09:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5G9e8wZ005509; Thu, 16 Jun 2011 09:40:08 GMT (envelope-from gnats) Date: Thu, 16 Jun 2011 09:40:08 GMT Message-Id: <201106160940.p5G9e8wZ005509@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Guillem Jover Cc: Subject: Re: kern/157879: [libgeom] ABI change without version bump in 8.2 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Guillem Jover List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2011 09:40:08 -0000 The following reply was made to PR kern/157879; it has been noted by GNATS. From: Guillem Jover To: bug-followup@FreeBSD.org, kaduk@mit.edu Cc: Subject: Re: kern/157879: [libgeom] ABI change without version bump in 8.2 Date: Thu, 16 Jun 2011 11:25:34 +0200 --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi! The ‘struct gprovider’ got two new members in the middle of a public struct, so this might cause programs built against the old headers to access the wrong member with the new library or the other way around. That's exactly what happened to us at least with grub2. I'm attaching the trivial patch we are using in Debian GNU/kFreeBSD. thanks, guillem --mP3DRpeJDSE+ciuQ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="libgeom_abi_bump.patch" Index: lib/libgeom/Makefile =================================================================== --- lib/libgeom/Makefile (revision 223144) +++ lib/libgeom/Makefile (working copy) @@ -1,6 +1,7 @@ # $FreeBSD$ LIB= geom +SHLIB_MAJOR= 1 SHLIBDIR?= /lib SRCS+= geom_getxml.c SRCS+= geom_stats.c --mP3DRpeJDSE+ciuQ--