Date: Mon, 31 Aug 2020 23:31:17 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r365015 - in head/sys/dev: an wi Message-ID: <202008312331.07VNVHlb006413@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Mon Aug 31 23:31:16 2020 New Revision: 365015 URL: https://svnweb.freebsd.org/changeset/base/365015 Log: Warn for the non pccard attachments These devices have non-pccard attachments. Warn for those as well. Both an and wi don't do the modern cyrpto needed to use these cards on secure wifi networks. an needs firmware from Cisco, which I don't think was ever produced. wi could in theory do it with raw frames and on-host encryption, but nobody has written that in the 15 years since WEP was cracked. MFC After: 3 days Noticed by: rgrimes Differential Revision: https://reviews.freebsd.org/D26138 Modified: head/sys/dev/an/if_an_isa.c head/sys/dev/an/if_an_pccard.c head/sys/dev/an/if_an_pci.c head/sys/dev/wi/if_wi_macio.c head/sys/dev/wi/if_wi_pccard.c head/sys/dev/wi/if_wi_pci.c Modified: head/sys/dev/an/if_an_isa.c ============================================================================== --- head/sys/dev/an/if_an_isa.c Mon Aug 31 22:44:59 2020 (r365014) +++ head/sys/dev/an/if_an_isa.c Mon Aug 31 23:31:16 2020 (r365015) @@ -127,6 +127,7 @@ an_attach_isa(device_t dev) an_release_resources(dev); return (error); } + gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto"); return (0); } Modified: head/sys/dev/an/if_an_pccard.c ============================================================================== --- head/sys/dev/an/if_an_pccard.c Mon Aug 31 22:44:59 2020 (r365014) +++ head/sys/dev/an/if_an_pccard.c Mon Aug 31 23:31:16 2020 (r365015) @@ -157,6 +157,6 @@ fail: if (error) an_release_resources(dev); else - gone_in_dev(dev, 13, "pccard removed"); + gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto"); return (error); } Modified: head/sys/dev/an/if_an_pci.c ============================================================================== --- head/sys/dev/an/if_an_pci.c Mon Aug 31 22:44:59 2020 (r365014) +++ head/sys/dev/an/if_an_pci.c Mon Aug 31 23:31:16 2020 (r365015) @@ -230,7 +230,8 @@ an_attach_pci(dev) NULL, an_intr, sc, &sc->irq_handle); if (error) device_printf(dev, "couldn't setup interrupt\n"); - + else + gone_in_dev(dev, 13, "pccard removed, an doesn't support modern crypto"); fail: if (error) an_release_resources(dev); Modified: head/sys/dev/wi/if_wi_macio.c ============================================================================== --- head/sys/dev/wi/if_wi_macio.c Mon Aug 31 22:44:59 2020 (r365014) +++ head/sys/dev/wi/if_wi_macio.c Mon Aug 31 23:31:16 2020 (r365015) @@ -142,6 +142,8 @@ wi_macio_attach(device_t dev) error = wi_attach(dev); if (error != 0) wi_free(dev); + else + gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto"); } return error; } Modified: head/sys/dev/wi/if_wi_pccard.c ============================================================================== --- head/sys/dev/wi/if_wi_pccard.c Mon Aug 31 22:44:59 2020 (r365014) +++ head/sys/dev/wi/if_wi_pccard.c Mon Aug 31 23:31:16 2020 (r365015) @@ -200,7 +200,7 @@ wi_pccard_attach(device_t dev) error = wi_attach(dev); if (error != 0) wi_free(dev); - gone_in_dev(dev, 13, "pccard removed"); + gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto"); } return error; } Modified: head/sys/dev/wi/if_wi_pci.c ============================================================================== --- head/sys/dev/wi/if_wi_pci.c Mon Aug 31 22:44:59 2020 (r365014) +++ head/sys/dev/wi/if_wi_pci.c Mon Aug 31 23:31:16 2020 (r365015) @@ -233,6 +233,8 @@ wi_pci_attach(device_t dev) error = wi_attach(dev); if (error != 0) wi_free(dev); + else + gone_in_dev(dev, 13, "pccard removed, wi doesn't support modern crypto"); return (error); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008312331.07VNVHlb006413>