From owner-svn-ports-head@freebsd.org Fri Apr 1 10:21:13 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9876AEBA0E; Fri, 1 Apr 2016 10:21:13 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A6F471E61; Fri, 1 Apr 2016 10:21:13 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: by shepard.synsport.net (Postfix, from userid 80) id BA71843CF8; Fri, 1 Apr 2016 05:21:11 -0500 (CDT) To: Thomas Zander , Mathieu Arnold Subject: Re: svn commit: r412296 - head/lang/rust MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 01 Apr 2016 12:21:11 +0200 From: "John Marino (FreeBSD)" Cc: Jan Beich , "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org Mail-Reply-To: marino@freebsd.org In-Reply-To: References: <201603312004.u2VK4n5n028013@repo.freebsd.org> Message-ID: <35bc4361c0a5c116b44b21bc4358e65e@secure.marino.st> X-Sender: freebsd.contact@marino.st User-Agent: Roundcube Webmail/0.9.1 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 10:21:13 -0000 On 4/1/2016 12:05 PM, Thomas Zander wrote: > On 1 April 2016 at 11:45, Mathieu Arnold wrote: > >> It is documented in the porter's handbook, where it all belongs: >> >> >> >> >> >> >> >> >> >> >> ww.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html> >> >> And, it is covered by the "Trivial and tested build and runtime >> fixes." >> bullet point. > > Thanks for stepping in, but I am a 100% sure that this statement will > not put the case to rest. Based on this statement: > - John will maintain his position that this commit was trivial, tested > and fixes a problem *on DragonFly* and hence *is* covered by the > blanket > - I will maintain my position that this commit does *not* fix a > problem *on FreeBSD* and hence is *not* covered by the blanket > > I am totally fine accepting any verdict from portmgr, but I want it to > be inescapably clear. Please review the commit and let us know once > and for all: Is this particular one covered by the blanket or not? > It appears lang/rust just became a critical port. It's now required for www/firefox. I was going to offer to remove DF support from lang/rust because we have two other rust ports, but if it's required for mozilla, I think DF testing becomes rather critical. Unless the dependency on rust by firefox is optional and DF can remove it? I would almost prefer that, the firefox dependency on rust scares me a lot. John