From nobody Tue Sep 9 01:52:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLRfF0wbwz67Nn2; Tue, 09 Sep 2025 01:52:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLRfF0BV0z3mDF; Tue, 09 Sep 2025 01:52:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757382757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jtf+TR2SFucC3KBha3rYNkkTukNyMVar96OfobwjQfc=; b=IOiif9shaEQNaT02POLhnonLN7g0vJLMsYW4rt0gzGbo+Glvy/Wj85fTXHzKd4zO+gvdLi Qm6iyiu+QT7b1Q40aWShhTTTevCeIaCNOBKuQgprlYOiEUhLDAiD0E9BiCTGwZP4CtqNvi 0oOVdmEEQXIDAuVngW2sTEASxoWZKAcCCO5EdSBL8f5NSz6RC//UjC/k3pXwLUXwq0L4a6 IMcl+pKgKmpjtxTRVGlzT2fBKRXI4IZPGysh2ofbWM3EOl2AfN7w7hkLn5NOjQdKTI5CUD lSPX6uePo30PkMaQjttHIbRMrLAyl9W+iWz/vzKmd6avVb1dbxw+g6SDyrAelg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757382757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jtf+TR2SFucC3KBha3rYNkkTukNyMVar96OfobwjQfc=; b=fMQ2ijbMhqsaRYjF4hN5wLANKg0GRPl76ZX0hJTtUQhb9PZDe6VE0k+Ci8V0V1SGhjkLYM z6tTvJmUk92q7o/9gddWnElDzG62WnaEEN+YYTfDn+CdZY0PdjtDB5noYetCkp6Jxl7cTF kzzSye9TJETVHJKq6ecBx55TAB9ofrzqrjNFjw8gzqh7XlilOnb1x4efj0fC7VI7KPrIIT 3AGEiPl0OaZj4lKF+zFYYz/aaiv3afGPyRLmrvdqmG4xVBw2JkSk/bdTaZ/yXAlxwRxTK6 NfdKcbA1/+TAITwGuMo/6aInINvX41mY2wTYQvRH29XbiDzzYdodpqktpGqWog== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757382757; a=rsa-sha256; cv=none; b=fBguUKetSO5lS09BezNH1BO7aQIEgCI2CQPkplq0pgrPFDz0s3AzjVXL41LZCNihp9NN4S arm9V5tDlN1/mE/wz0frnwWmbngngKmUSMQBcIo0BlvkHz1B7NeLMZkFMpssMHGkYMAi5j t/PZccwONmt1/I/MuMT+Ez9M18vPr3YSeOAcDZXnODWQ/rS+1M8yoNV0uVNZGeTF4mfE9z PtugU+3zYGRM3pwp4SN/JEfoGVtPBvyOsbnoigDS54pQcyD6jQZQ4vaklF4IDy7hjBKH0i 0bCU/p3GdennztdTjZEc83/CgIbKmIgILXgf8P46CqOqSNrsDNuuk5RmOW5yHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cLRfD6tCSzv0; Tue, 09 Sep 2025 01:52:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5891qauS058662; Tue, 9 Sep 2025 01:52:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5891qamU058659; Tue, 9 Sep 2025 01:52:36 GMT (envelope-from git) Date: Tue, 9 Sep 2025 01:52:36 GMT Message-Id: <202509090152.5891qamU058659@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: e76e631bb0e9 - main - run: enable seqno offload List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e76e631bb0e9d338f48f6208e7f8df9d76980abd Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=e76e631bb0e9d338f48f6208e7f8df9d76980abd commit e76e631bb0e9d338f48f6208e7f8df9d76980abd Author: Adrian Chadd AuthorDate: 2025-06-08 22:01:05 +0000 Commit: Adrian Chadd CommitDate: 2025-09-09 01:46:09 +0000 run: enable seqno offload Enable sequence number offload. This should both enable the sequence number offloading and disable the net80211 TX lock from being acquired/released/checked. Differential Revision: https://reviews.freebsd.org/D50747 Okayed by: bz --- sys/dev/usb/wlan/if_run.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sys/dev/usb/wlan/if_run.c b/sys/dev/usb/wlan/if_run.c index 97c790dd5b81..147aa4044057 100644 --- a/sys/dev/usb/wlan/if_run.c +++ b/sys/dev/usb/wlan/if_run.c @@ -882,6 +882,7 @@ run_attach(device_t self) ic->ic_flags |= IEEE80211_F_DATAPAD; ic->ic_flags_ext |= IEEE80211_FEXT_SWBMISS; + ic->ic_flags_ext |= IEEE80211_FEXT_SEQNO_OFFLOAD; run_getradiocaps(ic, IEEE80211_CHAN_MAX, &ic->ic_nchans, ic->ic_channels); @@ -3522,6 +3523,9 @@ run_tx(struct run_softc *sc, struct mbuf *m, struct ieee80211_node *ni) data->ni = ni; data->ridx = ridx; + /* Assign sequence number now, regardless of A-MPDU TX or otherwise (for now) */ + ieee80211_output_seqno_assign(ni, -1, m); + run_set_tx_desc(sc, data); /* @@ -3627,6 +3631,9 @@ run_tx_mgt(struct run_softc *sc, struct mbuf *m, struct ieee80211_node *ni) data->ni = ni; data->ridx = ridx; + /* Assign sequence number now, regardless of A-MPDU TX or otherwise (for now) */ + ieee80211_output_seqno_assign(ni, -1, m); + run_set_tx_desc(sc, data); RUN_DPRINTF(sc, RUN_DEBUG_XMIT, "sending mgt frame len=%d rate=%d\n", @@ -3771,6 +3778,9 @@ run_tx_param(struct run_softc *sc, struct mbuf *m, struct ieee80211_node *ni, break; data->ridx = ridx; + /* Assign sequence number now, regardless of A-MPDU TX or otherwise (for now) */ + ieee80211_output_seqno_assign(ni, -1, m); + run_set_tx_desc(sc, data); RUN_DPRINTF(sc, RUN_DEBUG_XMIT, "sending raw frame len=%u rate=%u\n", @@ -6416,6 +6426,10 @@ run_ampdu_enable(struct ieee80211_node *ni, struct ieee80211_tx_ampdu *tap) { /* For now, no A-MPDU TX support in the driver */ + /* + * TODO: maybe we needed to enable seqno generation too? + * What other TX desc bits are missing/needed? + */ return (0); }