From owner-cvs-all@FreeBSD.ORG  Fri Jun 15 09:38:57 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 7DAEA16A468; Fri, 15 Jun 2007 09:38:57 +0000 (UTC)
Date: Fri, 15 Jun 2007 09:38:57 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Pav Lucistnik <pav@FreeBSD.org>
Message-ID: <20070615093857.GA15320@FreeBSD.org>
References: <200706150811.l5F8Be2B093427@repoman.freebsd.org>
	<20070615081148.F318016A47D@hub.freebsd.org>
	<cb5206420706150208s51b60f83r5df09ac6d49328f@mail.gmail.com>
	<20070615092255.GA12182@FreeBSD.org>
	<1181899646.49728.39.camel@pav.hide.vol.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <1181899646.49728.39.camel@pav.hide.vol.cz>
User-Agent: Mutt/1.4.2.1i
Cc: infofarmer@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org,
	Xin LI <delphij@FreeBSD.org>, cvs-ports@FreeBSD.org,
	CHAO Shin <quakelee@cn.FreeBSD.org>
Subject: Re: cvs commit: ports/benchmarks/iozone Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2007 09:38:57 -0000

On Fri, Jun 15, 2007 at 11:27:26AM +0200, Pav Lucistnik wrote:
> Alexey Dokuchaev p??e v p? 15. 06. 2007 v 09:22 +0000:
> > On Fri, Jun 15, 2007 at 01:08:50PM +0400, Andrew Pantyukhin wrote:
> > > On 6/15/07, Xin LI <delphij@freebsd.org> wrote:
> > > >delphij     2007-06-15 08:11:40 UTC
> > > >
> > > >  FreeBSD ports repository
> > > >
> > > >  Modified files:
> > > >    benchmarks/iozone    Makefile
> > > >  Log:
> > > >  Add an option to use ssh instead of rsh in distributed measurement.
> > > >
> > > >  PR:             ports/113048
> > > >  Submitted by:   CHAO Shin <quakelee cn.FreeBSD.org>
> > > >  Approved by:    maintainer timeout
> > > >
> > > >  Revision  Changes    Path
> > > >  1.50      +6 -2      ports/benchmarks/iozone/Makefile
> > > >_______________________________________________
> > > >cvs-all@freebsd.org mailing list
> > > >http://lists.freebsd.org/mailman/listinfo/cvs-all
> > > >To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
> > > >
> > > >
> > > >Index: ports/benchmarks/iozone/Makefile
> > > >diff -u ports/benchmarks/iozone/Makefile:1.49 
> > > >ports/benchmarks/iozone/Makefile:1.50
> > > >--- ports/benchmarks/iozone/Makefile:1.49       Sat May 26 03:16:04 2007
> > > >+++ ports/benchmarks/iozone/Makefile    Fri Jun 15 08:11:40 2007
> > > >@@ -7,7 +7,7 @@
> > > >
> > > > PORTNAME=      iozone
> > > > PORTVERSION=   3.283
> > > >-PORTREVISION=  0
> > > >+PORTREVISION=  1
> > > > CATEGORIES=    benchmarks
> > > > MASTER_SITES=  http://www.iozone.org/src/current/
> > > > DISTNAME=      ${PORTNAME}${PORTVERSION:S/./_/}
> > > >@@ -27,7 +27,8 @@
> > > > MAN1=          iozone.1
> > > > PLIST_FILES=   bin/iozone
> > > >
> > > >-OPTIONS=       THREADS "Enable threading (uses pthreads)"      on
> > > >+OPTIONS=       THREADS "Enable threading (uses pthreads)"      on \
> > > >+               SSH "Use ssh in distributed measurement"        on
> > > >
> > > > .include <bsd.port.pre.mk>
> > > >
> > > >@@ -38,6 +39,9 @@
> > > > CFLAGS+=-DNO_THREADS
> > > > .endif
> > > >
> > > >+post-patch:
> > > >+       ${REINPLACE_CMD} -e 's|shell\,\"rsh\"|shell\,\"ssh\"|' 
> > > >${WRKSRC}/iozone.c
> > > >+
> > 
> > It also looks prettier in OPTIONS dialog if one spells either "SSH"
> > or "ssh(1)".
> 
> "ssh" is perfectly valid spelling.

I was talking about visual appeal, not grammatical correctness.  Not
that I think it's very important, of course.  :-)

./danfe