From owner-freebsd-current Thu Mar 13 03:17:23 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id DAA21171 for current-outgoing; Thu, 13 Mar 1997 03:17:23 -0800 (PST) Received: from spinner.DIALix.COM (spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id DAA21163 for ; Thu, 13 Mar 1997 03:17:00 -0800 (PST) Received: from spinner.DIALix.COM (localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.5/8.8.5) with ESMTP id TAA13938; Thu, 13 Mar 1997 19:12:48 +0800 (WST) Message-Id: <199703131112.TAA13938@spinner.DIALix.COM> X-Mailer: exmh version 2.0gamma 1/27/96 To: Bruce Evans cc: helbig@MX.BA-Stuttgart.De, current@FreeBSD.ORG Subject: Re: cvs commit: src/share/mk bsd.info.mk In-reply-to: Your message of "Thu, 13 Mar 1997 19:48:01 +1100." <199703130848.TAA03874@godzilla.zeta.org.au> Date: Thu, 13 Mar 1997 19:12:47 +0800 From: Peter Wemm Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans wrote: > >> Modified: share/mk bsd.info.mk > >> Log: > >> makeinfo can fail but still leave behind zero length files which cause > >> interesting problems because the resulting file is newer than the source > >> ... > > >Either this or the last change of bsd.info.mk seems to break "make world": > >... > >The bsd.info.mk created com_err.info instead of com_err.info.gz in > >/usr/obj/usr/src/lib/libcom_err. Something is wrong.. The "com_err.info.gz not found" was what the second last commit (rev 1.33) was supposed to fix. The "zero length result" change (rev 1.34) was in cases where texinfo files fail to build but make thinks that they did. It was rev 1.32 (by "wosch") that caused the first breakage that I can see. As far as I can tell, the breakage was not detected because either because of the brokenness in -current, or because it was tested with "NOINFOCOMPRESS" active. Please check what version you have in /usr/share/mk/bsd.info.mk. > It has at least three other bugs: > > 1. the new temporary files aren't in ${CLEANFILES}. No.. .info* includes the .info.new temporaries. > 2. support for not having --no-split in ${MAKEINFOFLAGS} is more broken > then before. "support" is not exactly what I'd call it. There is zero support for it and it requires quite a bit of work to do it. Since makeinfo doesn't have any way of notifying which (if any) extra .info-1 etc files are created (if any) so that installing them and cleaning them requires wildcard expansion. > 3. some too-long lines are longer than before. That's easily fixed... > Bruce Cheers, -Peter