From owner-cvs-all@FreeBSD.ORG Sat Jan 21 13:46:44 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FD1816A420; Sat, 21 Jan 2006 13:46:44 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep16-int.chello.at (viefep16-int.chello.at [213.46.255.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1424E43D49; Sat, 21 Jan 2006 13:46:42 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep16-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20060121134641.QPQL2804.viefep16-int.chello.at@wombat.fafoe.narf.at>; Sat, 21 Jan 2006 14:46:41 +0100 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 8FCFEBF4E; Sat, 21 Jan 2006 14:46:40 +0100 (CET) Date: Sat, 21 Jan 2006 14:46:40 +0100 From: Stefan Farfeleder To: Tom Rhodes Message-ID: <20060121134636.GC611@wombat.fafoe.narf.at> References: <200601211210.k0LCAXYl069896@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601211210.k0LCAXYl069896@repoman.freebsd.org> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2006 13:46:44 -0000 On Sat, Jan 21, 2006 at 12:10:33PM +0000, Tom Rhodes wrote: > trhodes 2006-01-21 12:10:33 UTC > > FreeBSD src repository > > Modified files: > sys/nfsserver nfs_serv.c > Log: > Remove some dead code. > > Found with: Coverity Prevent(tm) Hm, are you sure this change is correct? Apparently Coverity thinks that dirp is always 0 at this point, yes? Looking at nfs_namei() I don't believe that. Also the comment above this is now stale and the code inside 'if (error)' not indented properly. Stefan