From owner-freebsd-ports@FreeBSD.ORG Sun Jan 31 14:56:09 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E8CF3106568D for ; Sun, 31 Jan 2010 14:56:09 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from amailer.gwdg.de (amailer.gwdg.de [134.76.10.18]) by mx1.freebsd.org (Postfix) with ESMTP id A5A8D8FC1B for ; Sun, 31 Jan 2010 14:56:09 +0000 (UTC) Received: from p578b68b8.dip0.t-ipconnect.de ([87.139.104.184] helo=krabat.raven.hur) by mailer.gwdg.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1NbbDb-0005M4-CO; Sun, 31 Jan 2010 15:56:07 +0100 Message-ID: <4B659A06.7030309@gwdg.de> Date: Sun, 31 Jan 2010 15:56:06 +0100 From: Rainer Hurling User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; de-DE; rv:1.9.1.7) Gecko/20100122 Thunderbird/3.0.1 MIME-Version: 1.0 To: "b. f." References: <4B61EB16.9090205@gwdg.de> <4B6580B7.5040804@gwdg.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated: Id:rhurlin X-Spam-Level: - X-Virus-Scanned: (clean) by exiscan+sophie Cc: freebsd-ports@freebsd.org Subject: Re: Need help with new port math/ggobi X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2010 14:56:10 -0000 On 31.01.2010 15:36 (UTC+1), b. f. wrote: > On 1/31/10, Rainer Hurling wrote: >> I have a last question before I will do send-pr for my new port math/ggobi. >> >> The original program wants to install 'ggobi.pc' under >> >> /usr/local/lib/pkgconfig/ >> >> instead of >> >> /usr/local/libdata/pkgconfig/ >> >> I wrote a small patch in Makefile to change the location: >> >> post-patch: >> @${REINPLACE_CMD} -e >> 's|$$(libdir)/pkgconfig|${PREFIX}/libdata/pkgconfig|' \ >> ${WRKSRC}/Makefile.am \ >> ${WRKSRC}/Makefile.in >> >> Do you think this replacement is save enough if someone wants to install >> in another place? > > At first glance, it looks okay, although if you are not remaking > Makefile.in, you could probably just patch Makefile.in, and ignore > Makefile.am. But since you are already using some components of > Gnome, you could instead just add 'gnomehack' to USE_GNOME, which > already has some boilerplate code to do this, rather than adding your > own custom post-patch target. Also, I think that you can use @dirrm > instead of @dirrmtry for etc/xdg/ggobi (although not for etc/xdg). USE_GNOME gnomehack: Whow, I was not aware of it. Yes, it also takes care for the right place to install ggobi.pc. @dirrmtry etc/xdg/ggobi: This is because we can not be sure if a customized ggobirc file should remain for the next install or update. Many thanks again for your help. I think it is time to prepare a PR now :-) Rainer