Date: Fri, 19 Jan 1996 10:00:17 -0800 (PST) From: Julian Elischer <julian@ref.tfs.com> To: phk@critter.tfs.com (Poul-Henning Kamp) Cc: bde@zeta.org.au, jdli@linux.csie.nctu.edu.tw, freebsd-current@freebsd.org Subject: Re: [bug?] change in subr_diskslice.c Message-ID: <199601191800.KAA08126@ref.tfs.com> In-Reply-To: <293.822059315@critter.tfs.com> from "Poul-Henning Kamp" at Jan 19, 96 02:48:35 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > > >> sd1s1s2s3s4s5s1s2s4s5s6s4s1s2s5s2s1s2s4s5: error reading extended > > >This isn't too good either I belive I have a bug in the sprintf somewhere.. > . I think this explains the crashes people have been seeing with sprintf in the DEVFS code. i.e. sprintf(name,"rst%ld",unit); somehow seems to overflow a 32 byte string.. (either on read or write.. not sure which) > > > > I think sprintf() forgets to null-terminate the string, but I can't > > explain where "sd1s1s2..." came from. > > Yep, I fixed that one already, but I wonder about the s1s2... as well... > > BTW: anybody who compiled a kernel the last 72 hours should probably > recompile it now... > > -- > Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. > http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. > whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. > Future will arrive by its own means, progress not so. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601191800.KAA08126>