From owner-cvs-src@FreeBSD.ORG Tue Aug 16 09:05:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id E2F6116A420; Tue, 16 Aug 2005 09:05:52 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.3/8.13.1) with ESMTP id j7G986pw010097; Tue, 16 Aug 2005 05:08:10 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.3/8.13.1/Submit) id j7G984k1010096; Tue, 16 Aug 2005 05:08:04 -0400 (EDT) (envelope-from green) Date: Tue, 16 Aug 2005 05:08:03 -0400 From: Brian Fundakowski Feldman To: Pawel Jakub Dawidek Message-ID: <20050816090803.GD2660@green.homeunix.org> References: <200508120005.j7C05ARc090857@repoman.freebsd.org> <20050815053757.GB2660@green.homeunix.org> <20050815070033.GA8368@garage.freebsd.pl> <20050815125814.GC2660@green.homeunix.org> <20050816081644.GA3944@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050816081644.GA3944@garage.freebsd.pl> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/label g_label.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 09:05:54 -0000 On Tue, Aug 16, 2005 at 10:16:44AM +0200, Pawel Jakub Dawidek wrote: > On Mon, Aug 15, 2005 at 08:58:14AM -0400, Brian Fundakowski Feldman wrote: > +> > +> Why would we want to prevent the usage of a specific directory structure > +> > +> to represent GEOM's namespace, if that's what the administrator wants? > +> > > +> > If the label name is 'foo/bar' it doesn't seems right to create 'foo' > +> > directory and provider 'bar' inside. The label could be also '../random' > +> > or something like this and I want to save administrator/user nasty surprises > +> > when he inserts some random CD. > +> > +> I like the idea of rejecting the latter, but what is the harm of the first > +> case? If I call something "foo/bar", I'll be surprised to find out that > +> it's located at /dev/foo_bar... my preference would be for the name to be > +> rejected completely instead of remapped, if a '/' is to not be allowed, > +> but that's my own. > > # cd /dev/foo > # rm/anything bar > > There was no label 'bar', right. Anyway. Instead of rejecting labels with > '/' I can print a warning on the console that a bit different label will be > used. What do you say? That seems much more conservative -- GEOM doing a uprintf() and printf() to indicate that it's modified things. Something a sysadmin would notice at boot and a user at mount time of whatever. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\